| 1 |
On Wed, 2019-11-27 at 11:04 +0100, Ulrich Mueller wrote: |
| 2 |
> > > > > > On Wed, 27 Nov 2019, Michał Górny wrote: |
| 3 |
> > Update the skel variable order to place S immediately after SRC_URI. |
| 4 |
> > This seems to be a growing trend, and is quite reasonable given that |
| 5 |
> > S usually matches the archive name, and e.g. if SRC_URI uses MY_P, |
| 6 |
> > then S usually uses it as well: |
| 7 |
> > SRC_URI="http://example.com/${MY_P}.tar.gz" |
| 8 |
> > S=${WORKDIR}/${MY_P} |
| 9 |
> |
| 10 |
> My only concern is that this doesn't match the grouping of variables |
| 11 |
> in PMS. All other variables in these first blocks are ebuild-defined |
| 12 |
> variables [1], whereas S is not. |
| 13 |
|
| 14 |
To be honest, I never even realized this was the thing so far. |
| 15 |
I honestly doubt it makes much real difference to anyone, though, |
| 16 |
and the alternative has practical advantage of keeping relevant |
| 17 |
variables closer. |
| 18 |
|
| 19 |
> [1] https://projects.gentoo.org/pms/7/pms.html#x1-590007 |
| 20 |
|
| 21 |
-- |
| 22 |
Best regards, |
| 23 |
Michał Górny |
Archives