Gentoo Archives: gentoo-dev

From: Sam James <sam@g.o>
To: gentoo-dev@l.g.o
Cc: Benda Xu <heroxbd@g.o>
Subject: Re: [gentoo-dev] [PATCH] toolchain.eclass: the configure script shebang with BROOT.
Date: Wed, 01 Jun 2022 20:01:20
Message-Id: 6970B013-A9C1-44D6-9285-7D35D4FA12C9@gentoo.org
In Reply to: [gentoo-dev] [PATCH] toolchain.eclass: the configure script shebang with BROOT. by heroxbd@gentoo.org
1 > On 1 Jun 2022, at 16:34, heroxbd@g.o wrote:
2 >
3 > From: Benda Xu <heroxbd@g.o>
4 >
5 > It executes on CBUILD environment.
6 > ---
7 > eclass/toolchain.eclass | 2 +-
8 > 1 file changed, 1 insertion(+), 1 deletion(-)
9 >
10 > diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
11 > index 488648a82ab5..33306d3d92b1 100644
12 > --- a/eclass/toolchain.eclass
13 > +++ b/eclass/toolchain.eclass
14 > @@ -1655,7 +1655,7 @@ toolchain_src_compile() {
15 > # use of bash. Newer ones will auto-detect, but this is not harmful.
16 > # This needs to be set for compile as well, as it's used in libtool
17 > # generation, which will break install otherwise (at least in 3.3.6): bug #664486
18 > - CONFIG_SHELL="${EPREFIX}/bin/bash" \
19 > + CONFIG_SHELL="${BROOT}/bin/bash" \
20 > gcc_do_make ${GCC_MAKE_TARGET}
21 > }
22 >
23 > --
24 > 2.34.1
25 >
26 >
27
28 Please remember to CC the eclass maintainers on patches.
29
30 Anyway, lgtm, thanks, I'll push.

Attachments

File name MIME type
signature.asc application/pgp-signature