Re: [gentoo-dev] new eclass: golang-vcs-snapshot.eclass for golang vcs snapshots

[Mike Gilbert]

On Mon, Aug 3, 2015 at 8:20 PM, William Hubbs <williamh@g.o> wrote:
> This eclass is meant to handle vcs snapshots of golang packages coming
> from services like github.
>
> Let me know what you think.
>
> William
>
> # The location where the tarball is extracted is defined as
> # ${S}/src/${EGO_PN}.
>
> # @FUNCTION: golang-vcs-snapshot_src_unpack
>
> # @DESCRIPTION:
> # Extract the first archive from ${A} to the appropriate location for GOPATH.
> golang-vcs-snapshot_src_unpack() {
> local f destdir="${WORKDIR}/${P}" x
> ego_pn_check
> set -- ${A}
> x="$1"
> mkdir -p "${destdir}/src/${EGO_PN%/*}"
> tar -C "${destdir}/src/${EGO_PN%/*}" -x --strip-components 1 \
> -f "${DISTDIR}/${x}" || die
> }

The documentation says you are extracting to ${S}, but the function
actually extracts to ${WORKDIR}/${PN}.

I would get rid of the useless "destdir" variable and replace all
usages with "${S}". Or update the docs.