1 |
2010-07-05 18:36:09 Tomáš Chvátal napisał(a): |
2 |
> Dne 5.7.2010 18:34, Arfrever Frehtes Taifersar Arahesis napsal(a): |
3 |
> > 2010-07-05 18:26:40 Samuli Suominen napisał(a): |
4 |
> >> On 07/05/2010 07:17 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
5 |
> >>> 2010-07-05 18:13:26 Samuli Suominen napisał(a): |
6 |
> >>>> On 07/05/2010 06:23 PM, Arfrever Frehtes Taifersar Arahesis wrote: |
7 |
> >>>>> These minor changes in python.eclass and distutils.eclass have been already |
8 |
> >>>>> reviewed on alias of Gentoo Python Project. It's recommended to be familiar |
9 |
> >>>>> with internals of current code before trying to understand these minor changes. |
10 |
> >>>>> Suggestions about indentation and quoting will be rejected. |
11 |
> >>>>> |
12 |
> >>>> |
13 |
> >>>> You have been already told to get rid of all the color customizations in |
14 |
> >>>> the python eclasses here: |
15 |
> >>>> |
16 |
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c2 |
17 |
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c3 |
18 |
> >>>> |
19 |
> >>>> [ .. ] |
20 |
> >>>> |
21 |
> >>>> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
22 |
> >>>> |
23 |
> >>>> The bug was wrongly closed as fixed, as it's not really fixed before |
24 |
> >>>> it's all punted |
25 |
> >>> |
26 |
> >>> Colors can be used with echo. |
27 |
> >>> |
28 |
> >> |
29 |
> >> Stop using echo for output and switch to standard output functions, like |
30 |
> >> einfo/eerror/elog/... like told in |
31 |
> >> http://bugs.gentoo.org/show_bug.cgi?id=309057#c5 |
32 |
> > |
33 |
> > You should read relevant part of comment #7: |
34 |
> > "The colors can of course be continued to be used in outputs that are purely build |
35 |
> > time outputting and not for communicating things for users like what cmake builds do." |
36 |
> > |
37 |
> > python.eclass uses colors for build time outputting, which doesn't communicate anything for users. |
38 |
> > |
39 |
> + echo " ${_RED}*${_NORMAL} ${_RED}Deprecation Warning: NEED_PYTHON |
40 |
> variable is deprecated and will be banned on 2010-10-01.${_NORMAL}" |
41 |
> + echo " ${_RED}*${_NORMAL} ${_RED}Use PYTHON_DEPEND variable instead of |
42 |
> NEED_PYTHON variable.${_NORMAL}" |
43 |
> + echo " ${_RED}*${_NORMAL} ${_RED}The ebuild needs to be fixed. Please |
44 |
> report a bug, if it has not been already reported.${_NORMAL}" |
45 |
> |
46 |
> The above is build outputting since when? |
47 |
|
48 |
The colored, non-logged output in deprecation warnings is used as exception to increase |
49 |
the chance that ebuild maintainers will be notified earlier about the necessity of changes |
50 |
in given ebuilds. |
51 |
|
52 |
-- |
53 |
Arfrever Frehtes Taifersar Arahesis |