Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-dev@l.g.o, Matt Turner <mattst88@g.o>
Subject: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files
Date: Mon, 25 Feb 2019 06:38:11
Message-Id: w6gmumkfk5a.fsf@kph.uni-mainz.de
In Reply to: Re: [gentoo-dev] [PATCH 2/3] xorg-2.eclass: Remove use of prune_libtool_files by "Michał Górny"
1 >>>>> On Wed, 20 Feb 2019, Michał Górny wrote:
2
3 > On Wed, 2019-02-20 at 07:20 +0100, Ulrich Mueller wrote:
4 >> > > > > > On Wed, 20 Feb 2019, Matt Turner wrote:
5 >>
6 >>
7 >> > # Don't install libtool archives (even for modules)
8 >> > - prune_libtool_files --all
9 >> > + find "${D}" -name '*.la' -delete || die
10 >>
11 >> Maybe restrict removal to regular files, i.e. add "-type f"?
12
13 > I suppose you should have spoken up when people started adopting that
14 > 'find' line all over the place. Though I honestly doubt we're going
15 > to see many packages installing '*.la' non-files.
16
17 I have updated the example in ltprune.eclass now.
18
19 That still won't catch regular non-libtool files, but people needing
20 additional sanity checks can still use the eclass.
21
22 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies