[gentoo-dev] [PATCH 0/8] linux-info.eclass: cleanup & better non-Linux support

[Michał Górny]

Hi, everyone.

Here's a patch set for linux-info.eclass. Besides some minor cleanup,
it improves error handling and adds explicit handling for non-Linux
systems.

Currently, the eclass pretty much wrongly assumes that every system
is Linux. This causes e.g. a lot of spurious warnings or completely
random behavior on FreeBSD. While we could technically solve it
by adding appropriate conditionals to ebuilds, it seems pointless
to have to add it everywhere if the eclass can never be useful
for non-Linux targets.

For the purpose of these patches, I've split the public-ish API
of the eclass into three groups:

a. check_extra_config & pkg_setup are commonly used in 'assert'-style
   with non-fatal results. Those functions are made no-ops on non-Linux
   systems.

b. Some functions are fatal assert-style, i.e. die if kernel doesn't
   support X. Those now die explicitly on non-Linux systems (as they
   would probably anyway).

c. Functions that provide true/false results and get version can't work
   correctly on FreeBSD, and the failure can't be cleanly expressed
   in true/false (think of kernel_is). Those functions now also die
   on non-Linux systems and needs to be guarded in ebuilds.

Please review.

--
Best regards,
Michał Górny

Michał Górny (8):
  linux-info.eclass: get_localversion, do not call 'ls'
  linux-info.eclass: Replace unnecessary $? checks
  linux-info.eclass: linux-info_get_any_version, die on failure
  linux-info.eclass: Move get_version to require_configured_kernel
  linux-info.eclass: require_configured_kernel, improve error handling
  linux-info.eclass: Ignore check_extra_config on non-Linux
  linux-info.eclass: Die in most of public-ish APIs on non-Linux
  linux-info.eclass: Skip linux_config_*_exists on non-Linux

 eclass/linux-info.eclass | 72 ++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 58 insertions(+), 14 deletions(-)

-- 
2.16.2