1 |
On Sun, Oct 26, 2008 at 02:58:02PM -0700, Greg KH wrote: |
2 |
> On Sun, Oct 26, 2008 at 01:36:29PM -0400, Thomas Anderson wrote: |
3 |
> > On Sun, Oct 26, 2008 at 05:22:26PM +0000, Greg Kroah-Hartman (gregkh) wrote: |
4 |
> > > src_install() { |
5 |
> > > doman bti.1 |
6 |
> > > dobin bti |
7 |
> > > dodoc bti.example README RELEASE-NOTES |
8 |
> > > } |
9 |
> > You really should have some or all of these functions die on failure. |
10 |
> |
11 |
> Why would any of these fail if the src_compile succeeded? |
12 |
"Succeeded" and "Not error out" are different. Src_compile could not |
13 |
error out but still not produce the executables/produce an executable |
14 |
with a different name. Either way you end up with a broken installation |
15 |
of bti. |
16 |
> And, for some reason I thought that the default was that if there was an |
17 |
> error in them, they would "die" on their own. Is that not the case? |
18 |
No, they don't die on their own. As far as I know, very few ebuild |
19 |
functions do. Econf does, and epatch does as well. I'll look into |
20 |
writing up a list of which functions die and which don't though, for |
21 |
convenience. |