1 |
On Tue, 28 May 2002 07:18:37 +0200 |
2 |
"Per Wigren" <wigren@××××.se> wrote: |
3 |
|
4 |
> I just looked at the DOSEmu ebuild and saw that it contains LOTS of |
5 |
> "errors"... (although it does work at the moment(: |
6 |
> |
7 |
> > DESCRIPTION="DOSEmu 1.1.3 (Developer)" |
8 |
> Hmm.. What kind of description is that? :) Something like "DOS Emulator" would |
9 |
> be better.. |
10 |
> |
11 |
> > src_compile() { |
12 |
> > chmod +x $S/base-configure |
13 |
> chmod +x base-configure should be enough since we are already in ${S} .. |
14 |
> |
15 |
> >### mitshm will bork ./base-configure entirely, so we disable it here |
16 |
> > myflags="--enable-mitshm=yes" |
17 |
> |
18 |
> Hmm.. That doesn't look like disabling it to me, but I want it anyway, so... |
19 |
> :) |
20 |
> |
21 |
> >src_install () { |
22 |
> > ./install_systemwide -fd /usr/portage/distfiles/dosemu-freedos-bin.tgz -r |
23 |
> /var/tmp/portage/${PF}/image |
24 |
> |
25 |
> Should be |
26 |
> ./install_systemwide -fd ${DISTDIR}/dosemu-freedos-bin.tgz -r ${D} |
27 |
> |
28 |
> > rm -rf ${D}opt/dosemu/man |
29 |
> missing / |
30 |
> |
31 |
> // Wigren |
32 |
|
33 |
I agree with the changes proposed, but the more proper way *I think* is to contact the |
34 |
maintainer of the ebuild first, and propose the changes to them. |
35 |
|
36 |
-ryan |