| 1 |
On 08/20/2016 05:13 AM, Joshua Kinard wrote: |
| 2 |
> All, |
| 3 |
> |
| 4 |
> It looks like that sometime around Linux 3.15, some kind of a quirk was |
| 5 |
> introduced where a patch that contains the removal of a symlink followed by the |
| 6 |
> addition of a file with the same name as the symlink causes patch's --dry-run |
| 7 |
> phase to fail, which kills 'epatch'. See Bug #507656. |
| 8 |
> |
| 9 |
> A workaround was added to kernel-2.eclass, around line 1093, that hardcodes a |
| 10 |
> check for sys-kernel/git-sources, to avoid this issue. Well, |
| 11 |
> sys-kernel/mips-sources is also affected by the same issue. I'm close to |
| 12 |
> releasing a newer mips-sources, having spent the last few months |
| 13 |
> re-writing/refactoring chunks of old SGI IP27/BRIDGE code, and rather than add |
| 14 |
> another hardcode to kernel-2, I instead created a new variable, K_FROM_GIT, |
| 15 |
> that will replace the hardcode. |
| 16 |
> |
| 17 |
> When set to a value, it triggers the workaround, which still affects current |
| 18 |
> kernels. This results in a cleaner implementation instead of a hardcoded |
| 19 |
> ebuild, should future kernel packages sourced from a git repo get added. |
| 20 |
> |
| 21 |
> Patch is attached for review. |
| 22 |
> |
| 23 |
> Thanks! |
| 24 |
> |
| 25 |
|
| 26 |
lgtm, but I'm curious over the targeting of -rc releases. Are the only |
| 27 |
releases after 15 in the 3.x series -rc? If not, you're going to run |
| 28 |
into problems where a kernel is >=3.15 but not an rc. |
| 29 |
|
| 30 |
Otherwise it seems better than hardcoding it imo. |
| 31 |
|
| 32 |
-- |
| 33 |
Daniel Campbell - Gentoo Developer |
| 34 |
OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net |
| 35 |
fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6 |
Archives