Gentoo Archives: gentoo-dev

From: Stratos Psomadakis <psomas@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] git-2: a bunch of patches to review
Date: Tue, 20 Sep 2011 20:49:15
Message-Id: 4E78FC24.2060505@gentoo.org
In Reply to: [gentoo-dev] git-2: a bunch of patches to review by "Michał Górny"
1 On 09/20/2011 11:32 PM, Michał Górny wrote:
2 > Hello all,
3 >
4 > I've prepared a bunch of patches to git-2.eclass.
5 Just a suggestion (and maybe a bit off-topic), but I think if you sent
6 each patch separately, as replies to the original thread (git send-email
7 can do that), it would make the review of each patch easier (if that's
8 what you wanted :).
9 > 1-2 -- replacing scary unreadable parts of code with nicer ones.
10 > 3-4 -- basically just coding style changes.
11 > 5-7 -- little logic simplification.
12 > 8 -- eclassdoc fixes.
13 > 9 -- prevents environment injection of internal var.
14 > 10 -- tries to migrate git.eclass clones to git-2.eclass (#383761).
15 > 11 -- removes old git.eclass clones to not waste diskspace.
16 >
17 > In the future, I will probably attempt to remove most of directory
18 > changes in favor of GIT_DIR setting as well.
19 --
20 Stratos Psomadakis
21 <psomas@g.o>

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] git-2: a bunch of patches to review "Michał Górny" <mgorny@g.o>