| 1 |
El mar, 12-06-2012 a las 23:02 -0400, Mike Frysinger escribió: |
| 2 |
> i've noticed a growing trend where people put setup of variables into |
| 3 |
> pkg_setup that only matter to src_* funcs presumably so they don't have to |
| 4 |
> call the respective src_* func from an inherited eclass. unfortunately this |
| 5 |
> adds pointless overhead to binpkgs. can we please move away from this |
| 6 |
> practice ? |
| 7 |
> |
| 8 |
> i've seen this with a good number of the GNOME packages like: |
| 9 |
> pkg_setup() { |
| 10 |
> G2CONF="${G2CONF} |
| 11 |
> --disable-bash-completion |
| 12 |
> --disable-hal |
| 13 |
> --disable-schemas-compile |
| 14 |
> --with-dbus-service-dir=/usr/share/dbus-1/services |
| 15 |
> $(use_enable afp) |
| 16 |
> $(use_enable archive) |
| 17 |
> $(use_enable avahi) |
| 18 |
> $(use_enable bluetooth obexftp) |
| 19 |
> $(use_enable bluray) |
| 20 |
> $(use_enable cdda) |
| 21 |
> $(use_enable fuse) |
| 22 |
> $(use_enable gdu) |
| 23 |
> $(use_enable gphoto2) |
| 24 |
> $(use_enable ios afc) |
| 25 |
> $(use_enable udev) |
| 26 |
> $(use_enable udev gudev) |
| 27 |
> $(use_enable http) |
| 28 |
> $(use_enable gnome-keyring keyring) |
| 29 |
> $(use_enable samba)" |
| 30 |
> } |
| 31 |
> |
| 32 |
> ugh |
| 33 |
> -mike |
| 34 |
|
| 35 |
Will CC the rest of gnome team because I thought this way of passing |
| 36 |
configure options were intentional for some reason (or, at least, I |
| 37 |
remember being using it for a looong time) |
Archives