Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Sergei Trofimovich <slyfox@g.o>
Subject: Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild
Date: Tue, 29 Jun 2010 06:25:30
Message-Id: 201006290224.14248.vapier@gentoo.org
In Reply to: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild by Sergei Trofimovich
1 > if [[ -z "$1" ]]; then
2
3 either lose the quotes or lose the double brackets. hint: the former.
4
5 > echo "!!! xmms2_flag() called without a parameter." >&2
6 > echo "!!! xmms2_flag() <USEFLAG> [<xmms2_flagname>]" >&2
7
8 use eerror or die
9
10 > if use "$1"; then
11
12 USE flag cannot contain spaces or anything else that requires quoting
13
14 > else
15 > : # nothing is generated
16 > fi
17
18 my, we sure do like to be verbose
19
20 > --destdir="${D}" \
21
22 you need to give the DESTDIR to configure ? no wonder xmms2 sucks
23
24 > ${CTARGET:+--with-target-platform=${CTARGET}} \
25
26 i highly suspect this isnt what you think it is. if this option is for cross-
27 compiling, then use ${CHOST}.
28
29 > optionals+="$(xmms2_flag $option)"
30
31 dont need the quoting when doing ...=$(...)
32
33 > "${S}"/waf
34
35 the default dir for most src_* funcs is $S, so just use ./waf
36
37 > use python && python_mod_optimize $(python_get_sitedir)/xmmsclient
38
39 shouldnt sitedir be quoted ?
40 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild "Łukasz Michalik" <bronksos@×××××.com>
Re: [gentoo-dev] RFC: media-sound/xmms2/xmms2-0.7.ebuild (v2) Sergei Trofimovich <slyfox@g.o>