1 |
On Thu, Jun 21, 2018 at 03:41:02AM +0100, M. J. Everitt wrote: |
2 |
> On 21/06/18 03:38, Jason Zaman wrote: |
3 |
> > On Wed, Jun 20, 2018 at 06:01:10PM -0500, Marty E. Plummer wrote: |
4 |
> >> On Wed, Jun 20, 2018 at 11:33:53PM +0100, James Le Cuirot wrote: |
5 |
> >>> On Wed, 20 Jun 2018 17:21:09 -0500 |
6 |
> >>> "Marty E. Plummer" <hanetzer@×××××××××.com> wrote: |
7 |
> >>> |
8 |
> >>>> On Wed, Jun 20, 2018 at 09:03:44PM +0800, Jason Zaman wrote: |
9 |
> >>>>> On Wed, Jun 20, 2018 at 02:10:50AM -0500, Marty E. Plummer wrote: |
10 |
> >>>>>> Use ${EROOT%/} whereever possible, as the tools and directories which |
11 |
> >>>>>> are used with it are already prefixed with a / |
12 |
> >>>>>> |
13 |
> >>>>>> Package-Manager: Portage-2.3.40, Repoman-2.3.9 |
14 |
> >>>>>> --- |
15 |
> >>>>>> eclass/xdg-utils.eclass | 10 +++++----- |
16 |
> >>>>>> 1 file changed, 5 insertions(+), 5 deletions(-) |
17 |
> >>>>>> |
18 |
> >>>>>> diff --git a/eclass/xdg-utils.eclass b/eclass/xdg-utils.eclass |
19 |
> >>>>>> index ac075185d8e..8dba5ed6861 100644 |
20 |
> >>>>>> --- a/eclass/xdg-utils.eclass |
21 |
> >>>>>> +++ b/eclass/xdg-utils.eclass |
22 |
> >>>>>> @@ -66,7 +66,7 @@ xdg_environment_reset() { |
23 |
> >>>>>> # Updates the .desktop files database. |
24 |
> >>>>>> # Generates a list of mimetypes linked to applications that can handle them |
25 |
> >>>>>> xdg_desktop_database_update() { |
26 |
> >>>>>> - local updater="${EROOT}${DESKTOP_DATABASE_UPDATE_BIN}" |
27 |
> >>>>>> + local updater="${EROOT%/}${DESKTOP_DATABASE_UPDATE_BIN}" |
28 |
> >>>>> Shouldn't things like this be $BROOT since they're being run? $EROOT |
29 |
> >>>>> might be a different architecture that may or may not run at all on the |
30 |
> >>>>> build machine. |
31 |
> >>>>> |
32 |
> >>>> Good point, but here's a question; if EROOT=${ROOT%/}${EPREFIX}, how do |
33 |
> >>>> we use BROOT here? EBROOT? Or longhand ${BROOT%/}${EPREFIX} ? I think |
34 |
> >>>> that may be a use case that got missed in the EAPI 7 discussions. |
35 |
> >>> BROOT is already prefixed as BROOT without a prefix would just be /. |
36 |
> >>> |
37 |
> >> I don't follow. Its my understanding that BROOT ~= ROOT for most |
38 |
> >> situations. But consider this setup: |
39 |
> >> Ubuntu amd64 with Gentoo Prefix, emerging a native arm @system to |
40 |
> >> /mnt/arm EPREFIX = /home/user/gentoo. |
41 |
> >> |
42 |
> >> In this situation, ROOT=/mnt/arm, EROOT=/mnt/arm, but what is BROOT? /, |
43 |
> >> or /home/usr/gentoo? |
44 |
> > https://dev.gentoo.org/~mgorny/articles/the-ultimate-guide-to-eapi-7.html#broot-variable-for-bdepend |
45 |
> > |
46 |
> > Basically BROOT already contains EPREFIX or BPREFIX or whatever it would |
47 |
> > be called. There is like no need for an un-prefixed BROOT so its just |
48 |
> > merged in. so you should just need "${BROOT}/usr/bin/update-mime-database" |
49 |
> > |
50 |
> > -- Jason |
51 |
> > |
52 |
> >>> -- |
53 |
> >>> James Le Cuirot (chewi) |
54 |
> >>> Gentoo Linux Developer |
55 |
> >> |
56 |
> >> |
57 |
> Obligatory n00b question .. how does this work in EAPI <= 6 ?! :D |
58 |
> |
59 |
I would guess something like has eapi 7 || ROOT = BROOT or whatever. Use |
60 |
BROOT by default and if the EAPI doesn't support it set ROOT to BROOT or |
61 |
somat. |