1 |
On Fri, 29 Jul 2016 18:31:58 +0300 |
2 |
Andrew Savchenko <bircoph@g.o> wrote: |
3 |
|
4 |
> diff --git a/eclass/subversion.eclass b/eclass/subversion.eclass |
5 |
> index c45c725..49040a4 100644 |
6 |
> --- a/eclass/subversion.eclass |
7 |
> +++ b/eclass/subversion.eclass |
8 |
> @@ -434,6 +434,7 @@ subversion_src_unpack() { |
9 |
> # Default src_prepare. Bootstrap. |
10 |
> subversion_src_prepare() { |
11 |
> subversion_bootstrap || die "${ESVN}: unknown problem occurred in subversion_bootstrap." |
12 |
> + [[ ${EAPI:-0} -ge 6 ]] && eapply_user |
13 |
|
14 |
EAPI is not always a number, so this is wrong. |
15 |
|
16 |
Furthermore, since it didn't work in EAPI 6 anyway, please take a look |
17 |
into improving this eclass for EAPI 6. In particular: |
18 |
|
19 |
- add a proper EAPI check preventing it from implicitly being enabled |
20 |
in new EAPIs, |
21 |
|
22 |
- disable subversion_bootstrap() along with all the relevant facilities |
23 |
in EAPI 6 and later, therefore also stopping exporting src_prepare(). |
24 |
|
25 |
-- |
26 |
Best regards, |
27 |
Michał Górny |
28 |
<http://dev.gentoo.org/~mgorny/> |