Gentoo Archives: gentoo-dev

From: "Jorge Manuel B. S. Vicetto" <jmbsvicetto@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] git-2: a bunch of patches to review
Date: Thu, 22 Sep 2011 11:00:19
Message-Id: 4E7B14D4.2020507@gentoo.org
In Reply to: Re: [gentoo-dev] git-2: a bunch of patches to review by "Michał Górny"
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA1
3
4 On 22-09-2011 08:11, Michał Górny wrote:
5 > On Thu, 22 Sep 2011 09:01:17 +0200 Ulrich Mueller <ulm@g.o>
6 > wrote:
7 >
8 >>> Attaching fixed version of the last two patches, and a
9 >>> complete eclass for convenience.
10 >>
11 >> Just a general comment: Is it really necessary to change all [[
12 >> -n ${foo} ]] and [[ -z ${foo} ]] conditionals to the more
13 >> obscure [[ ${foo} ]] and [[ ! ${foo} ]]?
14 >>
15 >> The shortest possible form is not always the one that's best
16 >> readable.
17 >
18 > The style change was approved by Donnie already.
19
20 You mean that Donnie agreed with the style change. It's not up to any
21 individual developer to "approve" such a change for the entire tree.
22
23 - --
24 Regards,
25
26 Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org
27 Gentoo- forums / Userrel / Devrel / KDE / Elections / RelEng
28 -----BEGIN PGP SIGNATURE-----
29 Version: GnuPG v2.0.18 (GNU/Linux)
30 Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
31
32 iQIcBAEBAgAGBQJOexTUAAoJEC8ZTXQF1qEPMZ0QALNSTSCLwCKP9hd2BSt7HtP3
33 BzsJHr9Q+9+DpdwG9eRjbE0AnW1EbhpFmctPAnEszwC7I0NxID8vAsMw4HQS2MA8
34 wv2HKY14HYhSV9KBhHISn0i3tg8+LPwCpZJUYca4LWM+1o6brW/+MYEyzRBjWnMN
35 ljVEfK+to94+UvsPZyjvd0jRp3MuGVoATyXEDwHo1pNFC89Fq03J2YSvP6lPYE1V
36 J/Etw9PM5jJLWE7qQ8BlxHvf4FCWXZbAoOJ1kAFKLUp0v9AJeHssU84ZxZWDU/Rc
37 NjAiscFDXfhldL/DYlXFtZe24nF2V9aJ8DNFk+639f+L45oky5WNupiyRLMyn9ut
38 WAJAoPIoyQRccph5eAW2frrk7hUKhjsfS3uCDCB9otncQYpAFLK4X8USzRMEQlNV
39 QBBODOwccb/9BbwK6WGTywJiamB36dR9YGtdD6h+gULytRP9+WCK2HYGhQOAxumE
40 y+nVo4o5JAvHJ5W2IpCO611rbpyx/KXLGMu7my2OY06xrSsf1tU1DMEN+T3YtZ0s
41 s7TQRvbobKYmi4RsbQ/3J6ept5KldLLuhi4B/l/Nst2Di9bMCQ0bCHKcObeKsir+
42 LOb7zdVMwVAvCK1DvnPgFKMyR5LCfcHvdy1tD6UxwYlNUcm6SNMytb1QET/B0k4n
43 6Yyi7UQgCXfYWP5KL7TX
44 =4YOg
45 -----END PGP SIGNATURE-----

Replies

Subject Author
Re: [gentoo-dev] git-2: a bunch of patches to review "Michał Górny" <mgorny@g.o>