Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: peter@×××××.se
Subject: Re: [gentoo-dev] git-r3: initial draft for review
Date: Tue, 10 Sep 2013 07:23:16
Message-Id: 20130910091845.7fa99b6b@gentoo.org
In Reply to: Re: [gentoo-dev] git-r3: initial draft for review by Peter Stuge
1 Dnia 2013-09-10, o godz. 07:04:49
2 Peter Stuge <peter@×××××.se> napisał(a):
3
4 > Markos Chandras wrote:
5 > > the whole eclass is inside the " if [[ ! ${_GIT_R3} ]] " block.
6 >
7 > Rather than putting the whole eclass inside a block like that maybe
8 > it's possible to test for that condition and "exit" early?
9
10 Could you try your solutions before suggesting them on the list? It's
11 really something you could try at home in less than 5 minutes, and you
12 wouldn't have to make noise on the mailing list (not that anyone still
13 reads it). I think that you testing than would even take less time than
14 me answering it.
15
16 And in case you didn't want to do that: exiting ebuild process in middle
17 of inheritance chain is *not* a good idea. Portage will even give
18 an explanatory error for you.
19
20 --
21 Best regards,
22 Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] git-r3: initial draft for review Peter Stuge <peter@×××××.se>