| 1 |
(WilliamH: apologies for duplicate, I replied directly to you instead of |
| 2 |
the list the first time around) |
| 3 |
|
| 4 |
On Wed, Feb 19, 2020 at 12:10:46AM -0600, William Hubbs wrote: |
| 5 |
> > +EGO_PN=github.com/aquasecurity/kube-bench |
| 6 |
> You shouldn't need EGO_PN |
| 7 |
Copied from th previous -r0. |
| 8 |
|
| 9 |
> |
| 10 |
> > +DESCRIPTION="Kubernetes Bench for Security runs the CIS Kubernetes Benchmark" |
| 11 |
> > +HOMEPAGE="https://github.com/aquasecurity/kube-bench" |
| 12 |
> > + |
| 13 |
> > +EGO_SUM=( |
| 14 |
> > + "cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" |
| 15 |
> > + "cloud.google.com/go v0.34.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw=" |
| 16 |
> > + "cloud.google.com/go v0.37.4 h1:glPeL3BQJsbF6aIIYfZizMwc5LTYz250bDMjttbBGAU=" |
| 17 |
> > + "cloud.google.com/go v0.37.4/go.mod h1:NHPJ89PdicEuT9hdPXMROBD91xc5uRDxsMtSB16k7hw=" |
| 18 |
... |
| 19 |
> > +) |
| 20 |
> |
| 21 |
> There's a lot of duplication in here. For example, the only difference |
| 22 |
> between the last two lines is one has /go.mod tacked onto the end of the |
| 23 |
> version. Do we need both lines for each module? |
| 24 |
If we intend on validating h1: then yes, because we need to do it for |
| 25 |
the .zip and .mod. |
| 26 |
|
| 27 |
> > +src_unpack() { |
| 28 |
> > + unpack ${P}.tar.gz |
| 29 |
> > + go-module_src_unpack |
| 30 |
> > +} |
| 31 |
> Can we do this some how in go-module_src_unpack so we don't have to |
| 32 |
> boiler-plate it to every consumer? |
| 33 |
See discussion in eclass thread. |
| 34 |
|
| 35 |
-- |
| 36 |
Robin Hugh Johnson |
| 37 |
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer |
| 38 |
E-Mail : robbat2@g.o |
| 39 |
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85 |
| 40 |
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136 |
Archives