Re: [gentoo-dev] git-2.eclass review phase one

[Ulrich Mueller]

> # Eclass for easing maitenance of live ebuilds using git as remote repositories.

Please keep lines below 80 characters if possible.

> 	# @ECLASS-VARIABLE: ESCM_STORE_DIR
> 	# @DESCRIPTION:
> 	# Storage directory for git sources.
> 	: ${ESCM_STORE_DIR:="${PORTAGE_ACTUAL_DISTDIR-${DISTDIR}}/egit-src"}

Why is this renamed? It was EGIT_STORE_DIR before, and I think that
was more appropriate, especially when it's named egit-src.

> 	# @ECLASS-VARIABLE: ESCM_FETCH_CMD
> 	# @ECLASS-VARIABLE: ESCM_UPDATE_CMD
> 	# @ECLASS-VARIABLE: ESCM_OPTIONS
> 	# @ECLASS-VARIABLE: ESCM_MASTER
> 	# @ECLASS-VARIABLE: ESCM_REPO_URI
> 	# @ECLASS-VARIABLE: ESCM_BRANCH
> 	# @ECLASS-VARIABLE: ESCM_COMMIT

Same for all of these, they are all specific to git and should
therefore be named EGIT_*. Other VCSs have different concepts for some
of them.

> 	if [[ -z ${ESCM_REPO_URI%%:*} ]] ; then
> 		case ${ESCM_REPO_URI%%:*} in
> 			git*|http|https|rsync|ssh) ;;
> 			*) die "Protocol for fetch from "${ESCM_REPO_URI%:*}" is not yet implemented in eclass." ;;
> 		esac
> 	fi

This test won't work as intended.

> 		addwrite "${PORTAGE_ACTUAL_DISTDIR-${DISTDIR}}"
> 		mkdir -p "${ESCM_STORE_DIR}" \

Is it guaranteed that ${ESCM_STORE_DIR} is a subdir of
${PORTAGE_ACTUAL_DISTDIR-${DISTDIR}} if the former is freely
configurable?

Ulrich