Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: gentoo-dev@l.g.o
Cc: toolchain@g.o, Mike Gilbert <floppym@g.o>
Subject: [gentoo-dev] [PATCH 1/2] multilib.eclass: use tc-export to simplify multilib_toolchain_setup
Date: Sun, 14 Jun 2020 15:57:28
Message-Id: 20200614155706.1725903-1-floppym@gentoo.org
1 This also gives a tiny performance boost by reducing the number of
2 subshells that are forked.
3
4 Signed-off-by: Mike Gilbert <floppym@g.o>
5 ---
6 eclass/multilib.eclass | 12 ++++--------
7 1 file changed, 4 insertions(+), 8 deletions(-)
8
9 diff --git a/eclass/multilib.eclass b/eclass/multilib.eclass
10 index 342d21a2e1c3..29d44768adec 100644
11 --- a/eclass/multilib.eclass
12 +++ b/eclass/multilib.eclass
13 @@ -506,19 +506,15 @@ multilib_toolchain_setup() {
14 # Make sure ${save_restore_variables[@]} list matches below.
15 export CHOST=$(get_abi_CHOST ${DEFAULT_ABI})
16
17 - export AR="$(tc-getAR)" # Avoid 'ar', use '${CHOST}-ar'
18 + # Append ABI flags to CHOST-prefixed tools
19 export CC="$(tc-getCC) $(get_abi_CFLAGS)"
20 export CXX="$(tc-getCXX) $(get_abi_CFLAGS)"
21 export F77="$(tc-getF77) $(get_abi_CFLAGS)"
22 export FC="$(tc-getFC) $(get_abi_CFLAGS)"
23 export LD="$(tc-getLD) $(get_abi_LDFLAGS)"
24 - export NM="$(tc-getNM)" # Avoid 'nm', use '${CHOST}-nm'
25 - export OBJDUMP="$(tc-getOBJDUMP)" # Avoid 'objdump', use '${CHOST}-objdump'
26 - export PKG_CONFIG="$(tc-getPKG_CONFIG)"
27 - export RANLIB="$(tc-getRANLIB)" # Avoid 'ranlib', use '${CHOST}-ranlib'
28 - export READELF="$(tc-getREADELF)" # Avoid 'readelf', use '${CHOST}-readelf'
29 - export STRINGS="$(tc-getSTRINGS)" # Avoid 'strings', use '${CHOST}-strings'
30 - export STRIP="$(tc-getSTRIP)" # Avoid 'strip', use '${CHOST}-strip'
31 +
32 + # Use CHOST-prefixed tools
33 + tc-export AR NM OBJDUMP PKG_CONFIG RANLIB READELF STRINGS STRIP
34
35 export CHOST=$(get_abi_CHOST $1)
36 export PKG_CONFIG_LIBDIR=${EPREFIX}/usr/$(get_libdir)/pkgconfig
37 --
38 2.27.0

Replies