From: | "Bo Ørsted Andresen" <bo.andresen@××××.dk> | ||
---|---|---|---|
To: | gentoo-dev@l.g.o | ||
Cc: | stefaan@g.o | ||
Subject: | Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-fs/openafs: ChangeLog openafs-1.4.5_pre1.ebuild | ||
Date: | Sun, 14 Oct 2007 09:06:54 | ||
Message-Id: | 200710141053.50484.bo.andresen@zlin.dk | ||
In Reply to: | [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-fs/openafs: ChangeLog openafs-1.4.5_pre1.ebuild by Donnie Berkholz |
1 | On Sunday 14 October 2007 10:39:53 Donnie Berkholz wrote: |
2 | > On 14:25 Sat 13 Oct , Stefaan De Roeck (stefaan) wrote: |
3 | > > 1.1 net-fs/openafs/openafs-1.4.5_pre1.ebuild |
4 | > > |
5 | > > file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-fs/openafs/openafs-1.4.5_pre1.ebuild?rev=1.1&view=markup |
6 | > > plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/net-fs/openafs/openafs-1.4.5_pre1.ebuild?rev=1.1&content-type=text/plain |
7 | > > |
8 | > > PATCHDIR=${WORKDIR}/gentoo/patches/$(get_version_component_range 1-2) |
9 | > > CONFDIR=${WORKDIR}/gentoo/configs |
10 | > > SCRIPTDIR=${WORKDIR}/gentoo/scripts |
11 | > |
12 | > Repoman won't catch these, but they still need quotes. |
13 | |
14 | Actually they don't in assignments like these. In the rest of the ebuild |
15 | ${PATCHDIR}, ${CONFDIR} and ${SCRIPTDIR} need quotes though (the same applies |
16 | to variables such as ${oldafsconfdir}, ${newafsconfdir} etc.). This ebuild also |
17 | contains a lot of [ ... ] tests that should either be converted to [[ ... ]] or |
18 | have all variables inside them quoted. |
19 | |
20 | -- |
21 | Bo Andresen |
File name | MIME type |
---|---|
signature.asc | application/pgp-signature |
Subject | Author |
---|---|
Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-fs/openafs: ChangeLog openafs-1.4.5_pre1.ebuild | Donnie Berkholz <dberkholz@g.o> |