Gentoo Archives: gentoo-dev

From: Alec Warner <antarus@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] prune_libtool_files(): go into .a removal only when .a exists.
Date: Sat, 16 Jun 2012 08:08:52
Message-Id: CAAr7Pr-4SAd_+79PQUpDqfcV6FxpnF+KyPGMcW+bTbqBOMYbpw@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH] prune_libtool_files(): go into .a removal only when .a exists. by Mike Frysinger
On Fri, Jun 15, 2012 at 1:08 PM, Mike Frysinger <vapier@g.o> wrote:
> On Friday 15 June 2012 12:54:16 Michał Górny wrote: >> On Fri, 15 Jun 2012 11:11:44 -0400 Michael Orlitzky wrote: >> > On 06/15/12 09:32, Michał Górny wrote: >> > > It is a little confusing when the function reports .a removal when >> > > no such file exists. Also, explain why the file is removed. >> > >> > Why keep the "-f"? >> >> For rm? >> >>        -f, --force >>               ignore nonexistent files and arguments, never prompt >> >> The second part is still valid. > > i think his point was that since you just did a [[ -f ]] test, there shouldn't > really be any cases where the rm would fail, so you could change the `rm -f` > to `rm || die` ... > -mike
Just because you tested doesn't make the race go away; its not like the fs has locks. -A

Replies