[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: flag-o-matic.eclass

[Ryan Hill]

On Sat, 04 Apr 2009 17:57:54 +0000
"Fabian Groffen (grobian)" <grobian@g.o> wrote:

> grobian     09/04/04 17:57:54
>
>   Modified:             flag-o-matic.eclass
>   Log:
>   backport fix for x86-macos in filter-flags from Prefix
>
> Revision  Changes    Path
> 1.133                eclass/flag-o-matic.eclass
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/flag-o-matic.eclass?rev=1.133&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/flag-o-matic.eclass?rev=1.133&content-type=text/plain
> diff : http://sources.gentoo.org/viewcvs.py/gentoo-x86/eclass/flag-o-matic.eclass?r1=1.132&r2=1.133
>
> Index: flag-o-matic.eclass
> ===================================================================
> RCS file: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v
> retrieving revision 1.132
> retrieving revision 1.133
> diff -u -r1.132 -r1.133
> --- flag-o-matic.eclass	21 Jan 2009 00:42:20 -0000	1.132
> +++ flag-o-matic.eclass	4 Apr 2009 17:57:54 -0000	1.133
> @@ -1,6 +1,6 @@
>  # Copyright 1999-2009 Gentoo Foundation
>  # Distributed under the terms of the GNU General Public License v2
> -# $Header: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v 1.132 2009/01/21 00:42:20 gengor Exp $
> +# $Header: /var/cvsroot/gentoo-x86/eclass/flag-o-matic.eclass,v 1.133 2009/04/04 17:57:54 grobian Exp $
>
>  # @ECLASS: flag-o-matic.eclass
>  # @MAINTAINER:
> @@ -52,6 +52,12 @@
>  		-m32 -m64 -mabi -mlittle-endian -mbig-endian -EL -EB -fPIC \
>  		-mlive-g0 -mcmodel -mstack-bias -mno-stack-bias \
>  		-msecure-plt -m*-toc -D* -U*"
> +
> +	# killing these two on OSX/Intel will disable SSE, resulting in failing
> +	# compilations, as the headers expect SSE to be enabled (Apple knows what
> +	# hardware they run on afterall, don't they?)
> +	[[ ${CHOST} == i?86-apple-darwin* ]] \
> +		&& ALLOWED_FLAGS="${ALLOWED_FLAGS} -march=prescott -march=nocona"
>

Why do these have to be specifically included?  Aren't they handed by 

  34         export ALLOWED_FLAGS="${ALLOWED_FLAGS} -O -O0 -O1 -O2 -mcpu -march -mtune"



-- 
gcc-porting,                                      by design, by neglect
treecleaner,                              for a fact or just for effect
wxwidgets @ gentoo     EFFD 380E 047A 4B51 D2BD C64F 8AA8 8346 F9A4 0662