| 1 |
El mié, 24-09-2008 a las 02:35 +0200, Robert Buchholz escribió: |
| 2 |
> |
| 3 |
> Let's go with an even simpler default implementation: |
| 4 |
> |
| 5 |
> default_src_install() { |
| 6 |
> if [ -f Makefile ] || [ -f GNUmakefile ] || [ -f makefile ]; then |
| 7 |
> emake DESTDIR="${D}" install || die "emake install failed" |
| 8 |
> fi |
| 9 |
> if [ -n "${DOCS}" ]; then |
| 10 |
> dodoc ${DOCS} || die "dodoc failed" |
| 11 |
> fi |
| 12 |
> } |
| 13 |
> |
| 14 |
> It addresses the following issues: |
| 15 |
> * Do not run einstall if emake fails |
| 16 |
> * Run dodoc even if no Makefile is present, this might come in handy for |
| 17 |
> ebuilds calling default() |
| 18 |
> * die dodoc failure case |
| 19 |
> * hopefully fix the flaws (not really) pointed out by zlin |
| 20 |
> |
| 21 |
|
| 22 |
Looks far better. In my opinion, that would be an acceptable |
| 23 |
implementation of default_src_install. |
| 24 |
|
| 25 |
Regards, |
| 26 |
-- |
| 27 |
Santiago Moisés Mola |
| 28 |
Jabber: cooldwind@×××××.com | GPG: AAD203B5 |
Archives