Gentoo Archives: gentoo-dev

From: Daniel Campbell <zlg@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] rfc: dev-lang/go prefix patch hard coding a path to a binary
Date: Wed, 25 Nov 2015 19:13:42
Message-Id: 5656085A.4060303@gentoo.org
In Reply to: [gentoo-dev] rfc: dev-lang/go prefix patch hard coding a path to a binary by William Hubbs
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA256
3
4 On 11/23/2015 08:41 AM, William Hubbs wrote:
5 > All,
6 >
7 > there is a patch to dev-lang/go that was added a while back w/o
8 > consulting me [1]. I eventually did review the patch, and I see
9 > that it hard codes a path to the sysctl binary on OSx. In my view,
10 > prefix or not, we shouldn't be patching software to hard code paths
11 > to binaries; we should be fixing PATH instead.
12 >
13 > Thoughts?
14 >
15 > William
16 >
17 > [1] https://bugs.gentoo.org/show_bug.cgi?id=558368
18 >
19
20 I'm not a Go developer, but that *does* seem like the saner, standard
21 route to go about things.
22
23 - --
24 Daniel Campbell - Gentoo Developer
25 OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net
26 fpr: AE03 9064 AE00 053C 270C 1DE4 6F7A 9091 1EA0 55D6
27 -----BEGIN PGP SIGNATURE-----
28 Version: GnuPG v2
29
30 iQIcBAEBCAAGBQJWVghVAAoJEAEkDpRQOeFwS/oP/1dat4yDPBxcy92O7wQwgy+W
31 9QcL09VbzLtosMsTnTNI7GYFTEXQ+Y+Ec5KiF31xd7J4CEUy04aF+VYqK2RJlw6s
32 t6TSXFSILOAQ53IHR5rEE2Fxkk+31SFGgEh5J9wqezv3mo+0HLJPvaiktIDI9kSp
33 ORoP8KwOq828dJMOGzySOcLCf6tbHWXEkbMuC8j8NY6y+ncaNqsQBbDtVHksp7I2
34 UXu/XLFItjvi2eTkbyKD4s8uowSOy/EpACF/TN4ovRy7tZrkpCBwMm9O4YFGCrVp
35 BMuJuJOQwEBdLObjuOx8XNZLI9BHp/Pk+ApY6Qt5fMox2Vbax8YQpf5vRHtk6RfU
36 4uxCz14pr7UjOfBJw5n2JjxaYOlbhHugzq5bqNB0fDR+9ri9HcTELPd5heZxhTqt
37 9brJvnGjenmvd3++0sSEQ0XutbJZ6RFJFoeBnSGqbYsm4pRgwQUxlGtNDZb/QzaF
38 kPjSxZyTIGFkHR7vsRcfJ2kfaqWArhvMbpJBGYo/A5+vYf5gQC8LyWegfETok7f1
39 GzXIaU34x/TApLPOrEkg3B85bECxzEYAC+Hrt2KdMabh0ylHkJJNLmGRtSDopHKz
40 JvqD5hB+yRLS5b4F9VhoAiRC6Hbi1ApUQBbK+sOoGqOQYvb7evxWaVw4gAGg6YQo
41 ljpyM8Ue1ukjY5Luexg6
42 =bYlr
43 -----END PGP SIGNATURE-----