Gentoo Archives: gentoo-dev

From: Donnie Berkholz <dberkholz@g.o>
To: gentoo-dev@l.g.o, markusle@g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-visualization/paraview: paraview-2.6.2.ebuild ChangeLog paraview-3.2.1.ebuild
Date: Sun, 16 Dec 2007 07:21:30
Message-Id: 20071216071837.GV31432@supernova
1 On 19:59 Fri 14 Dec , Markus Dittrich (markusle) wrote:
2 > Index: paraview-3.2.1.ebuild
3 > ===================================================================
4 > # Copyright 1999-2007 Gentoo Foundation
5 > # Distributed under the terms of the GNU General Public License v2
6 > # $Header: /var/cvsroot/gentoo-x86/sci-visualization/paraview/paraview-3.2.1.ebuild,v 1.1 2007/12/14 19:59:46 markusle Exp $
7 >
8 > inherit distutils eutils flag-o-matic toolchain-funcs versionator python
9
10 I'm surprised to see this not using cmake-utils.eclass.
11
12 > src_compile() {
13 > cd "${BUILDDIR}"
14 > local CMAKE_VARIABLES=""
15 > CMAKE_VARIABLES="${CMAKE_VARIABLES} -DPV_INSTALL_LIB_DIR:PATH=/${PVLIBDIR}"
16 > CMAKE_VARIABLES="${CMAKE_VARIABLES} -DCMAKE_SKIP_RPATH:BOOL=YES"
17 > CMAKE_VARIABLES="${CMAKE_VARIABLES} -DVTK_USE_RPATH:BOOL=OFF"
18 > CMAKE_VARIABLES="${CMAKE_VARIABLES} -DCMAKE_INSTALL_PREFIX:PATH=/usr"
19 > CMAKE_VARIABLES="${CMAKE_VARIABLES} -DBUILD_SHARED_LIBS:BOOL=ON"
20
21 ...
22
23 Since this seems to go beyond the standard variable naming for cmake,
24 you could set up custom functions based on cmake-utils _use_me_now() for
25 e.g. VTK_USE, PARAVIEW_USE, CMAKE_USE. Also seems like this would be a
26 lot easier to read if it were a multiline variable...
27
28 Thanks,
29 Donnie
30 --
31 gentoo-dev@g.o mailing list