Gentoo Archives: gentoo-dev

From: Ulrich Mueller <ulm@g.o>
To: Mike Gilbert <floppym@g.o>
Cc: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst
Date: Thu, 15 Aug 2019 07:19:41
Message-Id: w6g7e7elwud.fsf@kph.uni-mainz.de
In Reply to: [gentoo-dev] [PATCH] acct-user.eclass: ignore missing directory in preinst by Mike Gilbert
1 >>>>> On Thu, 15 Aug 2019, Mike Gilbert wrote:
2
3 > + # Path might be missing due to INSTALL_MASK, etc.
4 > + # https://bugs.gentoo.org/691478
5 > + if [[ -e "${ED}/${ACCT_USER_HOME#/}" ]]; then
6 > + fowners "${ACCT_USER_HOME_OWNER}" "${ACCT_USER_HOME}"
7 > + fperms "${ACCT_USER_HOME_PERMS}" "${ACCT_USER_HOME}"
8 > + fi
9
10 IIUC, this would result in an entry for the directory in /etc/passwd,
11 but the directory wouldn't exist on the system?
12
13 I don't think that's a sane situation, so maybe the eclass should just
14 die here? (Basically, there are two possibilities: Either, things will
15 break if the dir is missing, then dying might be the best option.
16 Or, everything works without the dir, then the ebuild should set it to
17 /dev/null, in the first place.)
18
19 Ulrich

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies