1 |
This reply's just for minor wording things. If anyone's wanting to |
2 |
turn any of these into something more substantial, please change the |
3 |
subject and cut it back to one topic per subthread. |
4 |
|
5 |
On Tue, 21 Apr 2009 05:11:15 +0300 |
6 |
Mart Raudsepp <leio@g.o> wrote: |
7 |
> query/yes; but the default src_install maybe shouldn't be doing the |
8 |
> file exists and is greater than zero check, because dodoc in portage |
9 |
> already does that. Maybe formalize that and leave that check for dodoc |
10 |
> responsibility and don't bother checking twice? |
11 |
|
12 |
I'd rather leave it the way it is; otherwise things get confusing as |
13 |
dodoc's error handling behaviour gradually gets tightened up over newer |
14 |
EAPIs. |
15 |
|
16 |
> query. Lacks specification of what "correct" is in "must correctly |
17 |
> handle symlinks when installing recursively", so can't judge. |
18 |
|
19 |
I've tightened up the wording in PMS for that. |
20 |
|
21 |
> Also, would be interesting to know what sanity checks one would want |
22 |
> to apply in the future for absolute path symlinks in case they do not |
23 |
> start with $EPREFIX (don't honor --prefix)? Just curious for the |
24 |
> future on this one. |
25 |
|
26 |
There's already special behaviour mandated for merging absolute |
27 |
symlinks that point to things under $D. |
28 |
|
29 |
> Additionally the PMS draft has a typo: |
30 |
> |
31 |
> newinclude |
32 |
> As above, for doexample. Only in EAPIs listed in table 12.7 |
33 |
|
34 |
Fixed, thanks. |
35 |
|
36 |
|
37 |
> but also what if we want to display information based on saved |
38 |
> environment? Any suggestion into the spec which way to use for |
39 |
> checking if the package in question is already installed or not? |
40 |
|
41 |
has_version works there. |
42 |
|
43 |
> > * UNPACK-IF-COMPRESSED |
44 |
> |
45 |
> query |
46 |
> I think the spec draft reads that it will be an error to pass regular |
47 |
> files to unpack --if-compressed. That seems backwards. |
48 |
|
49 |
Uh, yeah, there's a missing 'not' or 'unless' there. Fixed. |
50 |
|
51 |
-- |
52 |
Ciaran McCreesh |