Gentoo Archives: gentoo-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-dev@l.g.o
Cc: ulm@g.o
Subject: Re: [gentoo-dev] [PATCH git-2.eclass 1/2] Clean up non-bare checkout before updating.
Date: Fri, 23 Dec 2011 21:49:53
Message-Id: 20111223224946.14ac4443@pomiocik.lan
In Reply to: Re: [gentoo-dev] [PATCH git-2.eclass 1/2] Clean up non-bare checkout before updating. by Ulrich Mueller
On Fri, 23 Dec 2011 22:09:26 +0100
Ulrich Mueller <ulm@g.o> wrote:

> >>>>> On Fri, 23 Dec 2011, Michał Górny wrote: > > > Fixes: https://bugs.gentoo.org/show_bug.cgi?id=395247 > > > + git clean -d -f -x || die "${FUNCNAME}: failed to > > clean checkout dir" + > > Why should there be untracked files, in the first place? (In the > "steps to reproduce" of bug 395247 such files are explicitly generated > by the user, which doesn't look like a valid usage case to me.)
Yes, it is invalid. Yet I think it's better to clean up just in case upstream pulling gone wrong (e.g. when upstream does rebase). -- Best regards, Michał Górny

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies