1 |
On Sat, Apr 18, 2015 at 5:15 AM, hasufell <hasufell@g.o> wrote: |
2 |
> On 04/17/2015 07:15 PM, Rich Freeman wrote: |
3 |
>> On Fri, Apr 17, 2015 at 10:41 AM, Alexander Berntsen |
4 |
>> <bernalex@g.o> wrote: |
5 |
>>> |
6 |
>>> On 17/04/15 16:33, Andrew Savchenko wrote: |
7 |
>>>> The problem is double effort: previously one developer effort was |
8 |
>>>> needed, now effort is doubled at least |
9 |
>>> You have correctly identified the problem; in order to do things |
10 |
>>> properly one must do things properly, which is more difficult than not |
11 |
>>> doing things properly. |
12 |
>>> |
13 |
>> |
14 |
>> "Properly" is just a matter of requirements. Gentoo has 18k packages |
15 |
>> right now. In my general experience, they install fine maybe 95% of |
16 |
>> the time. |
17 |
>> |
18 |
> |
19 |
> Can you back up your "general experience" with a tinderbox log? |
20 |
|
21 |
No. Of course, having a review workflow is orthogonal to having a tinderbox. |
22 |
|
23 |
> In addition, you are decreasing "QA" to "compiles". That's not the definition. |
24 |
|
25 |
If it makes you happy s/install/works. It is fairly rare to run into |
26 |
problems with Gentoo packages in my experience. |
27 |
|
28 |
> |
29 |
>> Right now we |
30 |
>> end up dropping packages because we can't find one person to maintain |
31 |
>> them. With a review workflow we'll drop packages if we can't find two |
32 |
>> people to maintain them. |
33 |
> |
34 |
> Nah, that's really not true. With a review workflow there is less need |
35 |
> for actual maintainers! That's the whole point. |
36 |
|
37 |
There is more need for actual maintainers. There is just less need |
38 |
for them to have commit access to the tree. |
39 |
|
40 |
If we instituted a policy that all commits needed to be reviewed it |
41 |
isn't like there would magically be a ton of pull requests headed our |
42 |
way. Users submit patches today, and users would submit patches |
43 |
tomorrow. We're not drowning in them today, and that is unlikely to |
44 |
change. There would still be nobody committing changes to java |
45 |
packages, just like today, and so on. |
46 |
|
47 |
> |
48 |
> I am really confused. I guess some people have never really been in a |
49 |
> different workflow than gentoo to know that it's really not |
50 |
> state-of-the-art. And it really isn't. Not even for distros. |
51 |
> |
52 |
|
53 |
I am not saying that a review workflow is bad. I just don't see how |
54 |
it fixes our actual problems, which is a lack of commits in the first |
55 |
place. |
56 |
|
57 |
You keep using the linux kernel as an example. The kernel has 8 |
58 |
patches per hour and the software is high-complexity. They need a |
59 |
review workflow to vet those changes and filter out the bad ones or |
60 |
get them reworked. Most committers are very motivated to get their |
61 |
code into the kernel. |
62 |
|
63 |
Other distros have MUCH larger userbases and active maintainer |
64 |
communities. They are also much simpler since they don't support |
65 |
mixing and matching random combinations of gcc, libfoo, and so on. |
66 |
|
67 |
Gentoo just doesn't have the same volume of incoming work. |
68 |
|
69 |
Now, if you're talking about making it easier to submit patches, |
70 |
having automated testing, and so on, I'm all for that. There are some |
71 |
already working on that and it will likely become more integrated into |
72 |
the core workflow when we migrate to git. Users can already submit |
73 |
pull requests using the github mirror. We just don't force everybody |
74 |
to do it that way. |
75 |
|
76 |
-- |
77 |
Rich |