| 1 |
On Tue, 3 Nov 2009 23:04:58 +0100 |
| 2 |
Patrick Lauer <patrick@g.o> wrote: |
| 3 |
> > If you want to fix PMS, then send a patch |
| 4 |
> I tried, and as I've been saying for a long time they get rejected. |
| 5 |
|
| 6 |
Yes, let's look at the patches that you sent that were rejected: |
| 7 |
|
| 8 |
The first was one where you asked the PMS team to make a change that |
| 9 |
goes directly against a Council decision, and that the PMS team does |
| 10 |
not have the authority to accept on its own. You were told to bring |
| 11 |
the issue to gentoo-dev@ for further attention. You never did. |
| 12 |
|
| 13 |
The second patch you sent: |
| 14 |
|
| 15 |
* incorrectly removed as "no content" two sentences that had specific |
| 16 |
and necessary meaning. |
| 17 |
|
| 18 |
* didn't apply against any version of PMS except your much-modified |
| 19 |
local version, and that didn't make sense when applied to version of |
| 20 |
PMS that anyone else had. |
| 21 |
|
| 22 |
Again, no updated patch was sent. |
| 23 |
|
| 24 |
The third patch you sent had a number of small issues and could have |
| 25 |
been improved. You did not send an updated patch with those issues |
| 26 |
fixed. |
| 27 |
|
| 28 |
> Funnily not by any dev but by some random user, but who cares :) |
| 29 |
|
| 30 |
Everyone on the PMS mailing list is more than welcome to do patch |
| 31 |
reviews. The more eyes we have looking at things the better. Policy is |
| 32 |
not to apply patches until everyone is happy with them; objections are |
| 33 |
considered on their merits, not on their author. |
| 34 |
|
| 35 |
Every other person who has had people comment upon a patch they |
| 36 |
submitted has either addressed the issues and submitted an updated |
| 37 |
patch, or explained why they feel the patch is correct as-is. |
| 38 |
|
| 39 |
Every other person who has submitted a patch has worked with all the |
| 40 |
reviewers to reach a conclusion that is acceptable to all involved. |
| 41 |
|
| 42 |
Every other person has an ultimate patch acceptance rate of at least |
| 43 |
98%. You are the *only* person to have had patches rejected where the |
| 44 |
submitter did not agree with the rejection. |
| 45 |
|
| 46 |
-- |
| 47 |
Ciaran McCreesh |
Archives