Gentoo Archives: gentoo-dev

From: Mike Gilbert <floppym@g.o>
To: Gentoo Dev <gentoo-dev@l.g.o>
Subject: Re: [gentoo-dev] [PATCH] acct-user.eclass: die explicitly if HOME is missing in preinst
Date: Thu, 15 Aug 2019 21:12:19
Message-Id: CAJ0EP43ifK2rX4Wza4dFfc-=zaBjNVaMZK7qm5dkN2Vm8O6fTg@mail.gmail.com
In Reply to: Re: [gentoo-dev] [PATCH] acct-user.eclass: die explicitly if HOME is missing in preinst by Michael Orlitzky
1 On Thu, Aug 15, 2019 at 3:01 PM Michael Orlitzky <mjo@g.o> wrote:
2 >
3 > On 8/15/19 11:43 AM, Mike Gilbert wrote:
4 > >
5 > > + # Path might be missing due to INSTALL_MASK, etc.
6 > > + # https://bugs.gentoo.org/691478
7 > > + if [[ ! -e "${ED}/${ACCT_USER_HOME#/}" ]]; then
8 > > + eerror "Home directory is missing from the installation image:"
9 > > + eerror " ${ACCT_USER_HOME}"
10 > > + eerror "Check INSTALL_MASK for entries that would cause this."
11 > > + die "${ACCT_USER_HOME} does not exist"
12 > > + fi
13 >
14 > This suggests that the problem is with the user's INSTALL_MASK, and not
15 > with the package that crashed. I would rather they file a bug than
16 > change their mask entry. But, I guess it's pretty easy these days to
17 > grep the whole acct-user category for issues like this that I missed on
18 > the mailing list.
19 >
20
21 The purpose of the message is to give the user a hint on how they may
22 resolve the issue themselves.