Gentoo Archives: gentoo-dev

From: Mike Frysinger <vapier@g.o>
To: gentoo-dev@l.g.o
Cc: Maciej Mrozowski <reavertm@×××××.com>
Subject: Re: [gentoo-dev] rewritten epatch
Date: Wed, 23 Nov 2011 23:45:59
Message-Id: 201111231845.28069.vapier@gentoo.org
In Reply to: Re: [gentoo-dev] rewritten epatch by Maciej Mrozowski
1 On Wednesday 23 November 2011 18:19:40 Maciej Mrozowski wrote:
2 > On Friday 18 of December 2009 20:07:47 Mike Frysinger wrote:
3 > > if (patch -p${count} ${EPATCH_OPTS} --dry-run -f <
4 > "${PATCH_TARGET}") >>
5 > > "${STDERR_TARGET}" 2>&1 ; then
6 >
7 > There seems to be a little 'problem' with this, as patch is validated in --
8 > dry-run mode before applying, no .rej files are generated, thus the only
9 > feedback is hunk # that failed from ${T}/${patchfile}.out.
10
11 this is always how epatch has worked. my rewrite didn't change that.
12
13 personally, i've never found .rej useful. and the .out file tells you exactly
14 what hunk failed, so i don't see a problem here.
15 -mike

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies

Subject Author
Re: [gentoo-dev] rewritten epatch Donnie Berkholz <dberkholz@g.o>