| 1 |
On 4/16/16 3:05 PM, Michał Górny wrote: |
| 2 |
> On Sat, 16 Apr 2016 19:01:02 +0000 (UTC) |
| 3 |
> "Anthony G. Basile" <blueness@g.o> wrote: |
| 4 |
> |
| 5 |
>> commit: ad0c2ab2bdbd34f4550e49c56cfd5974d6a2c07a |
| 6 |
>> Author: Anthony G. Basile <blueness <AT> gentoo <DOT> org> |
| 7 |
>> AuthorDate: Sat Apr 16 19:08:23 2016 +0000 |
| 8 |
>> Commit: Anthony G. Basile <blueness <AT> gentoo <DOT> org> |
| 9 |
>> CommitDate: Sat Apr 16 19:08:23 2016 +0000 |
| 10 |
>> URL: https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ad0c2ab2 |
| 11 |
>> |
| 12 |
>> ssl-cert.eclass: add libressl support |
| 13 |
>> |
| 14 |
>> eclass/ssl-cert.eclass | 12 ++++++++---- |
| 15 |
>> 1 file changed, 8 insertions(+), 4 deletions(-) |
| 16 |
>> |
| 17 |
>> diff --git a/eclass/ssl-cert.eclass b/eclass/ssl-cert.eclass |
| 18 |
>> index 002de76..2538f4d 100644 |
| 19 |
>> --- a/eclass/ssl-cert.eclass |
| 20 |
>> +++ b/eclass/ssl-cert.eclass |
| 21 |
>> @@ -30,10 +30,10 @@ |
| 22 |
>> |
| 23 |
>> if [[ "${SSL_DEPS_SKIP}" == "0" ]]; then |
| 24 |
>> if [[ "${SSL_CERT_MANDATORY}" == "0" ]]; then |
| 25 |
>> - DEPEND="${SSL_CERT_USE}? ( dev-libs/openssl:0= )" |
| 26 |
>> + DEPEND="${SSL_CERT_USE}? ( || ( dev-libs/openssl:0= dev-libs/libressl:0= ) )" |
| 27 |
>> IUSE="${SSL_CERT_USE}" |
| 28 |
>> else |
| 29 |
>> - DEPEND="dev-libs/openssl:0=" |
| 30 |
>> + DEPEND="|| ( dev-libs/openssl:0= dev-libs/libressl:0= )" |
| 31 |
>> fi |
| 32 |
>> fi |
| 33 |
>> |
| 34 |
> |
| 35 |
> Congratulations! You've just committed an invalid dependency that is |
| 36 |
> going to cause true mayhem on every package using the eclass. |
| 37 |
> |
| 38 |
> But why would anyone send patches for review, or even start wondering |
| 39 |
> that we might be using USE=libressl all around for some reason... |
| 40 |
> |
| 41 |
|
| 42 |
It was discussed on the bug report and I asked robbat2. Revert then. |
| 43 |
|
| 44 |
-- |
| 45 |
Anthony G. Basile, Ph.D. |
| 46 |
Gentoo Linux Developer [Hardened] |
| 47 |
E-Mail : blueness@g.o |
| 48 |
GnuPG FP : 1FED FAD9 D82C 52A5 3BAB DC79 9384 FA6E F52D 4BBA |
| 49 |
GnuPG ID : F52D4BBA |
Archives