| 1 |
On Sat, 2003-11-22 at 22:21, Ian Leitch wrote: |
| 2 |
> I always put IUSE at the top of my ebuilds even if it doesn't use any. |
| 3 |
> The benefit being that anyone who ventures into the ebuild can see |
| 4 |
> straight away if/what USE flags it has. |
| 5 |
> Its still very obvious the package doesn't use USE flags if IUSE isn't |
| 6 |
> in there, but I think its good to be clear/definate/organized/what ever. |
| 7 |
> The same should go for all other variables IMO, if they are unused set |
| 8 |
> them "". |
| 9 |
|
| 10 |
I have to agree. The ONLY time IUSE should be left out is when the |
| 11 |
ebuild calls an eclass which sets IUSE (such as games) and the ebuild |
| 12 |
uses the same USE variables as the eclass. |
| 13 |
|
| 14 |
> On Sun, 2003-11-23 at 00:37, Alastair Tse wrote: |
| 15 |
> > Hi All, |
| 16 |
> > |
| 17 |
> > I've come across a peculiar inconsistency with one tiny aspect of the |
| 18 |
> > Gentoo Development Policy which would probably bore everyone except for |
| 19 |
> > the most pedantic and anal developers. |
| 20 |
> > |
| 21 |
> > I was reading through the Gentoo Developer HOWTO (aka. Ebuild HOWTO)[1] |
| 22 |
> > as all developers should (yes, I'm looking at you ;) and found that the |
| 23 |
> > field IUSE is declared as an optional field. |
| 24 |
> > |
| 25 |
> > I've brought this up on gentoo-doc and also on bugzilla[2], but there |
| 26 |
> > doesn't seem to be any authoritative answer on whether IUSE should be |
| 27 |
> > included even if a package does not use and USE flags. |
| 28 |
> > |
| 29 |
> > From a earlier revision (1.13) of the Developer Policy, it says: |
| 30 |
> > |
| 31 |
> > IUSE : This is set to what USE variables your package uses. If your |
| 32 |
> > package uses none, you must set it to IUSE="". |
| 33 |
> > |
| 34 |
> > However, the current document states that: |
| 35 |
> > |
| 36 |
> > IUSE : OPT : This is set to whatever USE variables your package |
| 37 |
> > utilizes. Remember that KEYWORDS should not be listed in here! |
| 38 |
> > |
| 39 |
> > (where OPT = optional) |
| 40 |
> > |
| 41 |
> > Now, which one is right? Should we include IUSE="" if there are no USE |
| 42 |
> > variables being used, or should we just remove them? |
| 43 |
> > |
| 44 |
> > I don't mind either way, because adding an extra 7 characters to an |
| 45 |
> > ebuild doesn't do me or a user a great deal of harm. But it would be |
| 46 |
> > nice to be clear on what the policy should be. |
| 47 |
> > |
| 48 |
> > [1] http://www.gentoo.org/doc/en/gentoo-howto.xml |
| 49 |
> > [2] http://bugs.gentoo.org/show_bug.cgi?id=34131 |
| 50 |
> > |
| 51 |
> > Cheers, |
| 52 |
-- |
| 53 |
Chris Gianelloni |
| 54 |
Developer, Gentoo Linux |
| 55 |
Games Team |
| 56 |
|
| 57 |
Is your power animal a penguin? |
Archives