| 1 |
On Mon, 12 Nov 2012 21:34:42 +0100 |
| 2 |
Fabian Groffen <grobian@g.o> wrote: |
| 3 |
|
| 4 |
> On 12-11-2012 21:30:20 +0100, Michał Górny wrote: |
| 5 |
> > --- |
| 6 |
> > gx86/eclass/systemd.eclass | 28 ++++++++++++---------------- |
| 7 |
> > 1 file changed, 12 insertions(+), 16 deletions(-) |
| 8 |
> > |
| 9 |
> > diff --git a/gx86/eclass/systemd.eclass b/gx86/eclass/systemd.eclass |
| 10 |
> > index 47e342b..bb1ec7f 100644 |
| 11 |
> > --- a/gx86/eclass/systemd.eclass |
| 12 |
> > +++ b/gx86/eclass/systemd.eclass |
| 13 |
> > @@ -69,10 +69,9 @@ systemd_get_utildir() { |
| 14 |
> > systemd_dounit() { |
| 15 |
> > debug-print-function ${FUNCNAME} "${@}" |
| 16 |
> > |
| 17 |
> > - ( |
| 18 |
> > - insinto "$(_systemd_get_unitdir)" |
| 19 |
> > - doins "${@}" |
| 20 |
> > - ) |
| 21 |
> > + local INSDESTTREE |
| 22 |
> > + insinto "$(_systemd_get_unitdir)" |
| 23 |
> > + doins "${@}" |
| 24 |
> |
| 25 |
> Isn't this a bit ugly and assuming knowledge that you better not? |
| 26 |
|
| 27 |
A bit maybe but still less ugly than inducing local scope through |
| 28 |
subshelling. |
| 29 |
|
| 30 |
And the knowledge is all in the PMS. It is 100% legit. |
| 31 |
|
| 32 |
-- |
| 33 |
Best regards, |
| 34 |
Michał Górny |
Archives