Gentoo Archives: gentoo-dev

From: Jeremy Olexa <darkside@g.o>
To: gentoo-dev@l.g.o, keri@g.o
Cc: gentoo-commits@l.g.o
Subject: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in net-misc/pedro: metadata.xml ChangeLog pedro-1.5.ebuild
Date: Sat, 03 Jul 2010 00:33:37
Message-Id: 526367928f28e98f8af1f607ceafd9bc@localhost
1 On Fri, 2 Jul 2010 23:59:34 +0000 (UTC), "Keri Harris (keri)"
2 <keri@g.o> wrote:
3 > Index: pedro-1.5.ebuild
4 > ===================================================================
5 > # Copyright 1999-2010 Gentoo Foundation
6 > # Distributed under the terms of the GNU General Public License v2
7 > # $Header: /var/cvsroot/gentoo-x86/net-misc/pedro/pedro-1.5.ebuild,v
8 > 1.1 2010/07/02 23:59:34 keri Exp $
9 >
10 > EAPI=1
11 >
12 > inherit eutils
13
14 Why do you need to inherit eutils? Nothing uses it.
15
16 >
17 > DESCRIPTION="Pedro is a subscription/notification communications system"
18 > HOMEPAGE="http://www.itee.uq.edu.au/~pjr/HomePages/PedroHome.html"
19 > SRC_URI="http://www.itee.uq.edu.au/~pjr/HomePages/PedroFiles/${P}.tgz
20 > doc? ( mirror://gentoo/${PN}-manual-${PV}.tar.gz )"
21 >
22 > LICENSE="GPL-2"
23 > SLOT="0"
24 > KEYWORDS="~amd64 ~ppc ~sparc ~x86"
25 > IUSE="doc examples"
26 >
27 > DEPEND="dev-libs/glib:2"
28 >
29 > S="${WORKDIR}"/${P}
30 >
31 > src_unpack() {
32 > unpack ${A}
33 > cd "${S}"
34 > }
35
36 This is the default src_unpack and can be dropped.
37
38 >
39 > src_compile() {
40 > econf || die "econf failed"
41 > emake || die "emake failed"
42 > }
43
44 econf() doesn't need "|| die" but furthermore, this is the default
45 src_compile and can be dropped.
46
47 >
48 > src_install() {
49 > emake DESTDIR="${D}" install || die "emake install failed"
50 >
51 > dodoc AUTHORS README
52 >
53 > if use doc ; then
54 > dodoc "${WORKDIR}"/${PN}.pdf
55 > fi
56 >
57 > if use examples ; then
58 > insinto /usr/share/doc/${PF}/examples
59 > doins src/examples/*.{c,tcl}
60 > doins src/java_api/*.java
61 > doins src/python_api/*.py
62 > fi
63 > }
64
65 Those are just cosmetic fixes above, but this should be fixed:
66
67 * QA Notice: Files built without respecting LDFLAGS have been detected
68 * Please include the following list of files in your report:
69 * /usr/bin/pedro
70 * /usr/bin/ptick
71
72 Thanks,
73 Jeremy

Replies