Gentoo Archives: gentoo-dev

From: Georgy Yakovlev <gyakovlev@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: [PATCH] profiles/base/make.defaults: ENV_UNSET CARGO_HOME
Date: Sun, 30 Aug 2020 21:11:42
Message-Id: 34bf7279-b8a2-4f3f-8acc-c1aefc624ed6@gentoo.org
In Reply to: [gentoo-dev] [PATCH] profiles/base/make.defaults: ENV_UNSET CARGO_HOME by Georgy Yakovlev
1 On 8/28/20 2:09 PM, Georgy Yakovlev wrote:
2 > CARGO_HOME may leak into ebuild environment and lead to
3 > write attempts to directory specified.
4 > This is explicitly taken care of in cargo.eclass, but
5 > ebuilds that don't use the eclass can still be affected.
6 >
7 > Signed-off-by: Georgy Yakovlev <gyakovlev@g.o>
8 > ---
9 > profiles/base/make.defaults | 2 +-
10 > 1 file changed, 1 insertion(+), 1 deletion(-)
11 >
12 > diff --git a/profiles/base/make.defaults b/profiles/base/make.defaults
13 > index 1ac69f51ec9..9f570d905c8 100644
14 > --- a/profiles/base/make.defaults
15 > +++ b/profiles/base/make.defaults
16 > @@ -40,7 +40,7 @@ CONFIG_PROTECT_MASK="/etc/env.d /etc/gconf"
17 > # GOBIN needs to be cleaned as random values in GOBIN can affect the
18 > # building of some packages:
19 > # https://archives.gentoo.org/gentoo-dev/message/163010f83ae7819d80c0cfdf797cbfe0
20 > -ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR PERL_MM_OPT PERL5LIB PERL5OPT PERL_MB_OPT PERL_CORE PERLPREFIX GOBIN GOPATH"
21 > +ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR PERL_MM_OPT PERL5LIB PERL5OPT PERL_MB_OPT PERL_CORE PERLPREFIX GOBIN GOPATH CARGO_HOME"
22 >
23 > # Variables that are set exclusively by the profile
24 > # and not by user configuration files.
25 >
26
27 Pushed.