[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sys-cluster/openmpi: ChangeLog openmpi-1.1.1.ebuild openmpi-1.2.4.ebuild

[Donnie Berkholz]

On 02:10 Thu 13 Dec     , Justin Bronder (jsbronder) wrote:
> 1.1                  sys-cluster/openmpi/openmpi-1.2.4.ebuild
>
> file : http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/openmpi/openmpi-1.2.4.ebuild?rev=1.1&view=markup
> plain: http://sources.gentoo.org/viewcvs.py/gentoo-x86/sys-cluster/openmpi/openmpi-1.2.4.ebuild?rev=1.1&content-type=text/plain

> 	if [[ -n "${FORTRANC}" ]]; then

This should be 'if use fortran' like the one earlier, to make it clear 
what you're really testing: whether it's a fortran-enabled build.

> 		if [[ "${FORTRANC}" = "g77" ]]; then
> 			myconf="${myconf} --disable-mpi-f90"
> 		elif [[ "${FORTRANC}" = "gfortran" ]]; then
> 			# Because that's just a pain in the butt.
> 			myconf="${myconf} --with-wrapper-fflags=-I/usr/include"
> 		fi
> 	else
> 		myconf="${myconf}
> 			--disable-mpi-f90
> 			--disable-mpi-f77"
> 	fi
>
> 	econf ${myconf} \
> 		$(use_enable !nocxx mpi-cxx) \
> 		$(use_enable romio romio-io) \
> 		$(use_enable smp smp-locks) \
> 		$(use_enable heterogeneous heterogeneous) \

You don't need the second argument, it's identical to the first if not 
present.

> 		$(use_with pbs tm /usr/$(get_libdir)/pbs) \
> 		$(use_with slurm) \
> 		$(use_enable ipv6) \
> 	|| die "econf failed"
>
> 	emake  || die "emake failed"
> }
>
> src_install () {
> 	make DESTDIR="${D}" install || die "make install failed"
> 	dodoc README AUTHORS NEWS VERSION
> }

Does emake work?

Thanks,
Donnie
-- 
gentoo-dev@g.o mailing list