[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in media-gfx/nvidia-cg-toolkit/files: 80cgc-opt-2

[justin]

On 16/11/12 09:48, Samuli Suominen wrote:
> On 16/11/12 00:07, Justin Lecher (jlec) wrote:
>> jlec        12/11/15 22:07:13
>>
>>    Modified:             80cgc-opt-2
>>    Log:
>>    media-gfx/nvidia-cg-toolkit: Version BUmp, #270480, thanks Myckel Habets, Piotr Szymaniak and Jean-Marc Hengen working on the ebuild; add multilib support, #262477, thanks Russell Harmon and Dennis Schridde working on this; Add additional variables to enviroment to find headers and libs, #344603
>>
>>    (Portage version: 2.2.0_alpha142/cvs/Linux x86_64, signed Manifest commit with key 8009D6F070EB7916)
>>
>> Revision  Changes    Path
>> 1.2                  media-gfx/nvidia-cg-toolkit/files/80cgc-opt-2
>>
>> file : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-gfx/nvidia-cg-toolkit/files/80cgc-opt-2?rev=1.2&view=markup
>> plain: http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-gfx/nvidia-cg-toolkit/files/80cgc-opt-2?rev=1.2&content-type=text/plain
>> diff : http://sources.gentoo.org/viewvc.cgi/gentoo-x86/media-gfx/nvidia-cg-toolkit/files/80cgc-opt-2?r1=1.1&r2=1.2
>>
>> Index: 80cgc-opt-2
>> ===================================================================
>> RCS file: /var/cvsroot/gentoo-x86/media-gfx/nvidia-cg-toolkit/files/80cgc-opt-2,v
>> retrieving revision 1.1
>> retrieving revision 1.2
>> diff -u -r1.1 -r1.2
>> --- 80cgc-opt-2	15 Nov 2012 21:12:55 -0000	1.1
>> +++ 80cgc-opt-2	15 Nov 2012 22:07:13 -0000	1.2
>> @@ -1,7 +1,11 @@
>> -# $Header: /var/cvsroot/gentoo-x86/media-gfx/nvidia-cg-toolkit/files/80cgc-opt-2,v 1.1 2012/11/15 21:12:55 jlec Exp $
>> +# $Header: /var/cvsroot/gentoo-x86/media-gfx/nvidia-cg-toolkit/files/80cgc-opt-2,v 1.2 2012/11/15 22:07:13 jlec Exp $
>>
>>   # Configures the CG Runtime environment for Bourne shell and compatible shells
>>   CG_COMPILER_EXE=@GENTOO_PORTAGE_EPREFIX@/opt/bin/cgc
>> +CG_INC_PATH=@GENTOO_PORTAGE_EPREFIX@/opt/nvidia-cg-toolkit/include
>> +CG_LIB_PATH="ELDPATH"
>>
>> -# Make sure the helper files are found
>> -LDPATH="/opt/nvidia-cg-toolkit/lib"
>> +PATH="@GENTOO_PORTAGE_EPREFIX@/opt/nvidia-cg-toolkit/bin"
>> +ROOTPATH="@GENTOO_PORTAGE_EPREFIX@/opt/nvidia-cg-toolkit/bin"
>> +
>> +LDPATH="ELDPATH"
>
> does this mean it puts the binary-only package, nvidia-cg-toolkit, to
> the default search path when you call the linker (compiler)?

right, I trusted what Mike committed before.

>
> please don't do that, it is counterproductive with the purpose of
> putting libraries to /opt. binary only packages should be isolated.
>
> it was already once reverted for the package...
>
> it is up the the ebuilds using nvidia-cg-toolkit to append-ldflags
> -L/opt/... or similar.
>
> thanks
>

That's true. I will fix this by adding support for pkg-config.

Thanks,

Justin