1 |
On Wed, Nov 30, 2016 at 6:16 AM, Jeroen Roovers <jer@g.o> wrote: |
2 |
> On Tue, 29 Nov 2016 10:39:04 -0500 |
3 |
> Mike Gilbert <floppym@g.o> wrote: |
4 |
> |
5 |
>> On Tue, Nov 29, 2016 at 9:14 AM, Jeroen Roovers <jer@g.o> |
6 |
>> wrote: |
7 |
>> > --- a/eclass/linux-mod.eclass |
8 |
>> > +++ b/eclass/linux-mod.eclass |
9 |
>> > @@ -566,6 +566,9 @@ linux-mod_pkg_setup() { |
10 |
>> > return |
11 |
>> > fi |
12 |
>> > |
13 |
>> > + # External modules use kernel symbols (bug #591832) |
14 |
>> > + export CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS" |
15 |
>> > + |
16 |
>> > linux-info_pkg_setup; |
17 |
>> > require_configured_kernel |
18 |
>> > check_kernel_built; |
19 |
>> > |
20 |
>> |
21 |
>> There is no need to export CONFIG_CHECK to the environment here. |
22 |
> |
23 |
> Interesting. The same is done in linux-mod_pkg_setup_binary(), so which? |
24 |
|
25 |
As far as I know, it's a bash variable used by functions defined in |
26 |
linux-info.eclass. It does not need to be passed to any child |
27 |
processes, and so it does not need to be defined in the environment. |
28 |
|
29 |
The export in linux-mod_pkg_setup_binary is unnecessary as well. |