1 |
Hi, |
2 |
|
3 |
|
4 |
Excerpts from Michal Hrusecky's message of 2011-09-13 13:11:28 +0200: |
5 |
> Comments and improvements are welcome. |
6 |
|
7 |
Just some minor remarks: |
8 |
|
9 |
|
10 |
> [[ -z ${OPENSUSE_RELEASE} ]] || OBS_PROJECT="openSUSE:${OPENSUSE_RELEASE}" |
11 |
> [[ -n ${OBS_PROJECT} ]] || die "OBS_PROJECT not set!" |
12 |
> [[ -n ${OBS_PACKAGE} ]] || die "OBS_PACKAGE not set!" |
13 |
|
14 |
You don't need -n/-z with [[. |
15 |
|
16 |
[[ $var ]] == [[ -n $var ]] |
17 |
[[ ! $var ]] == [[ -z $var ]] |
18 |
|
19 |
So: |
20 |
|
21 |
[[ ${OPENSUSE_RELEASE} ]] && OBS_PROJECT="openSUSE:${OPENSUSE_RELEASE}" |
22 |
[[ ${OBS_PROJECT} ]] || die "OBS_PROJECT not set!" |
23 |
[[ ${OBS_PACKAGE} ]] || die "OBS_PACKAGE not set!" |
24 |
|
25 |
> obs-service_src_install() { |
26 |
> debug-print-function ${FUNCNAME} "$@" |
27 |
> debug-print "Installing service \"${OBS_SERVICE_NAME}\"" |
28 |
> exeinto /usr/lib/obs/service |
29 |
> doexe ${DISTDIR}/${OBS_SERVICE_NAME} |
30 |
> insinto /usr/lib/obs/service |
31 |
> doins ${DISTDIR}/${OBS_SERVICE_NAME}.service |
32 |
> if [[ -n ${ADDITIONAL_FILES} ]]; then |
33 |
> debug-print "Installing following additional files:" |
34 |
> debug-print " ${ADDITIONAL_FILES}" |
35 |
> exeinto /usr/lib/obs/service/${OBS_SERVICE_NAME}.files |
36 |
> for i in ${ADDITIONAL_FILES}; do |
37 |
> doexe ${DISTDIR}/$i |
38 |
|
39 |
"" just in case. |
40 |
|
41 |
> done |
42 |
> fi |
43 |
> } |
44 |
|
45 |
-- |
46 |
Amadeusz Żołnowski |
47 |
|
48 |
PGP key fpr: C700 CEDE 0C18 212E 49DA 4653 F013 4531 E1DB FAB5 |