1 |
Dnia 2013-08-28, o godz. 09:01:54 |
2 |
Ian Stakenvicius <axs@g.o> napisał(a): |
3 |
|
4 |
> -----BEGIN PGP SIGNED MESSAGE----- |
5 |
> Hash: SHA256 |
6 |
> |
7 |
> On 28/08/13 07:30 AM, Vadim A. Misbakh-Soloviov wrote: |
8 |
> >> 4. Kill EGIT_MASTER (it's more trouble than benefit), |
9 |
> > |
10 |
> > Only if EGIT_BRANCH will stay on it's place. |
11 |
> > |
12 |
> |
13 |
> ..and work as well as EGIT_MASTER. I've had issues at times trying to |
14 |
> get the branch checkout I wanted via setting EGIT_BRANCH, while |
15 |
> setting it via EGIT_MASTER "just worked". Never looked into why. |
16 |
|
17 |
And never cared enough to report a bug, did you? |
18 |
|
19 |
> Also, please ensure that there is a way to override the branch |
20 |
> checkout on the command line (ie, if EGIT_MASTER is unset in the |
21 |
> ebuild, using EGIT_MASTER="branch" emerge =foo-9999 is a nice way to |
22 |
> test something that hasn't been merged into master yet). |
23 |
|
24 |
There's ${PN}_LIVE_BRANCH variable that is designed exactly for that. |
25 |
I'd honestly kill it as well but I guess it won't hurt me much if it is |
26 |
left as-is. |
27 |
|
28 |
-- |
29 |
Best regards, |
30 |
Michał Górny |