Gentoo Archives: gentoo-dev

From: Alexis Ballier <aballier@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424
Date: Fri, 24 Mar 2017 08:58:11
Message-Id: 20170324095755.0d3620f6@gentoo.org
In Reply to: Re: [gentoo-dev] Re: [PATCH] sys-devel/autoconf: Convert from eblits into an eclass, #586424 by David Seifert
1 On Thu, 23 Mar 2017 22:45:54 +0100
2 David Seifert <soap@g.o> wrote:
3
4 > On Thu, 2017-03-23 at 22:42 +0100, Alexis Ballier wrote:
5 > > On Thu, 23 Mar 2017 17:20:59 -0400
6 > > Michael Orlitzky <mjo@g.o> wrote:
7 > >
8 > > > On 03/23/2017 04:22 PM, Alexis Ballier wrote:
9 > > > >
10 > > > > Indeed, according to pms.git commit log, the rule was laxed
11 > > > > because
12 > > > > it was clearly an oversight in EAPI6 [1] and was the standard
13 > > > > behavior in previous EAPIs. But in the same commit, an "harmless
14 > > > > note" was added that "Ebuilds must not access the directory in
15 > > > > global scope." in addition to the "May or may not exist"
16 > > > > statement
17 > > > > and "Not necessarily present when installing from a binary
18 > > > > package"
19 > > > > footnote. Please explain how this last addition is not a
20 > > > > backwards-breaking change. PMS is not a tool to push your
21 > > > > personal
22 > > > > agenda of cleaning up the deve^^err tree.
23 > > > >
24 > > > >
25 > > > > [1]
26 > > > > https://gitweb.gentoo.org/proj/pms.git/commit/?id=fa4ac9474048ec7
27 > > > > 5af138fc61f22485c06aac5b7
28 > > > >  
29 > > >
30 > > > Read that diff again. Before the commit, FILESDIR was invalid in
31 > > > global scope (only valid in src_*). This commit makes it valid in
32 > > > global scope, but adds the "... don't access it there" clause.
33 > > >
34 > > > It's not a breaking change because any behavior affected by the
35 > > > clause was already illegal before the commit.
36 > >
37 > >
38 > > If we were to stop thinking and follow the rule by the letter: What
39 > > are
40 > > we waiting for to file bugs for every package having ${FILESDIR}
41 > > somewhere in global scope then ?
42 > > After all, those are the council approved versions and EAPIs cannot
43 > > change.
44 > >
45 > > Or you can read again the first sentence in the part you quoted.
46 > >
47 >
48 > https://bugs.gentoo.org/show_bug.cgi?id=586416
49 >
50
51 yep, that's about tracking access to the dir not to the variable itself

Replies