Gentoo Archives: gentoo-dev

From: Steve Long <slong@××××××××××××××××××.uk>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: Re: Hooks are gone from java eclasses
Date: Tue, 07 Aug 2007 03:58:21
Message-Id: f98qf7$mn2$2@sea.gmane.org
In Reply to: Re: [gentoo-dev] Re: Hooks are gone from java eclasses by "Petteri Räty"
1 Petteri Räty wrote:
2 > Steve Long kirjoitti:
3 >> Petteri Räty wrote:
4 >>> http://bugs.gentoo.org/show_bug.cgi?id=163262
5 >>>
6 >> What is the situation regarding the hooks in general?
7 > A user feature as said in the bug.
8 >
9 What, you mean the bit I quoted? I am well aware it's a "user feature,"
10 surprisingly enough.
11
12 >>>> They're a horrible solution. They don't stack and they override
13 >>>> something that is used by users. What's going to happen if anyone else
14 >>>> starts using the same functions?
15 >>> It's primarily a user feature, introduced due to the usefulness of
16 >>> /etc/portage/bashrc breaking down with proper env state handling.
17 >>>
18 >> <snip>
19 >>> If paludis doesn't want to support (pre|post)_*, whatever, long term it
20 >>> was only a user feature.
21 >>>
22 >>> Short term, it's part of the required env support.
23 >>>
24 >> The "only a user feature" bothers me tbh. Is it so hard to make the
25 >> functions stack then?
26 >>
27 >
28 > Hard or not, read and understand what the whole EAPI stuff is about.
29 > Feel free to propose stuff for EAPI-1 but to do that you should be able
30 > to grasp what is useful and what is not. For that one should have lots
31 > of ebuild writing experience.
32 >
33 That's nice; I really don't see the relevance. The question was: why can't
34 this be implemented in a sane (ie stackable) fashion? I wasn't even talking
35 about proposing stuff for EAPI=1, just enquiring about the general state of
36 hooks since there didn't seem to be a clear consensus from the bug.
37
38 >>
39 >> (I'm thinking along the lines of an eclass which defines foo_src_unpack
40 >> which can be called by an ebuild function if overridden.)
41 >>
42 >
43 > Which would be how eclasses already work.
44 >
45 Yes, that was my point: why is that not appropriate for this set of
46 functions?
47
48
49 --
50 gentoo-dev@g.o mailing list