1 |
I agree. I think that any "master" version of whatever repo we use should |
2 |
be hosted on gentoo owned infrastructure. |
3 |
|
4 |
Github might be allowed to take pull requests but I think it should be a |
5 |
slave to whatever's hosted on gentoo. |
6 |
|
7 |
That way if anything gets screwed up on github gentoo could always hit the |
8 |
big fat reset button on gitub |
9 |
|
10 |
|
11 |
On Sun, Sep 13, 2015 at 10:56 AM, Andrew Savchenko <bircoph@g.o> |
12 |
wrote: |
13 |
|
14 |
> On Sat, 12 Sep 2015 21:12:25 +0200 Michał Górny wrote: |
15 |
> > Hello, everyone. |
16 |
> > |
17 |
> > The current workflow for handling github pull requests is at least |
18 |
> > suboptimal. Handling pull requests takes a fair effort from the few |
19 |
> > developers contributing there, and the progress is often stalled by |
20 |
> > package maintainers which are either unresponsive or not registered on |
21 |
> > github at all. That's why I'd like to get your ideas on how we could |
22 |
> > improve the workflow. |
23 |
> > |
24 |
> > |
25 |
> > |
26 |
> > Current workflow |
27 |
> > ================ |
28 |
> > |
29 |
> > Let's summarize the current workflow first. Right now, there's a few |
30 |
> > Gentoo developers who actively monitor pull requests on gentoo/gentoo |
31 |
> > repository. Those developers review incoming pull requests and help |
32 |
> > submitters get their contributions in shape. Some of those developers |
33 |
> > also try to 'CC' (@-mention) package maintainers to get their attention |
34 |
> > on the pull request. |
35 |
> > |
36 |
> > Sadly, @-mentioning sucks for a few reasons: |
37 |
> > |
38 |
> > 1. Many of the Gentoo developers have different nicknames on GitHub. |
39 |
> > Some developers don't even set their real names which makes them even |
40 |
> > harder to find. |
41 |
> > |
42 |
> > 2. Teams can be created only by repository 'owners' (which pretty much |
43 |
> > is equivalent of Infra). Which practically means I'm the only person |
44 |
> > migrating teams (projects, herds) to GitHub. |
45 |
> > |
46 |
> > 3. GitHub notifications are not very reliable. Some developers get only |
47 |
> > some of them via mail, some don't. And some simply don't care. |
48 |
> > |
49 |
> > 4. Some developers openly refuse to work with contributors via GitHub. |
50 |
> > Proxying them manually is not really productive. |
51 |
> > |
52 |
> > |
53 |
> > |
54 |
> > Potential solution: bi-dir github <=> bugzilla integration |
55 |
> > ========================================================== |
56 |
> > |
57 |
> > My current idea would be pretty much that: |
58 |
> > |
59 |
> > 1. a new dedicated Gentoo bug would be automatically created for every |
60 |
> > pull request on github, |
61 |
> > |
62 |
> > 2. all comments from github would be automatically copied to bugzie. |
63 |
> > All bugzie comments would be automatically copied to github, |
64 |
> > |
65 |
> > 3. resolving the bug would automatically close the relevant pull |
66 |
> > request. |
67 |
> > |
68 |
> > This way, all pull requests can be assigned to package maintainers in |
69 |
> > Bugzilla without having to resort to GitHub user or team names. All |
70 |
> > involved parties would get more reliable Bugzilla notification mails. |
71 |
> > They could choose to either use the provided URLs to discuss the pull |
72 |
> > request on GitHub, or discuss it directly on Bugzilla, whichever is |
73 |
> > more convenient to them. |
74 |
> > |
75 |
> > The additional Bugzilla load should be manageable, though we may want |
76 |
> > to employ some kind of rate limiting in case someone though it'd funny |
77 |
> > to spam our bugzilla via spamming github. |
78 |
> > |
79 |
> > Problems: |
80 |
> > |
81 |
> > - handling line comments (probably a Bugzie comment with quoted code |
82 |
> > snippet), |
83 |
> > |
84 |
> > - handling comment edits and removals, |
85 |
> > |
86 |
> > - some people will get double mail for each comment, |
87 |
> > |
88 |
> > - extra bugs for existing issues (we shouldn't really try to reuse |
89 |
> > existing bugs for this). |
90 |
> > |
91 |
> > |
92 |
> > |
93 |
> > What are your thoughts? Any other proposals? |
94 |
> |
95 |
> Gentoo workflow should not depend on a proprietary tools like |
96 |
> github issue tracker and github pull requests. |
97 |
> |
98 |
> Best regards, |
99 |
> Andrew Savchenko |
100 |
> |