1 |
On Tue, 19 Aug 2008 23:31:17 +0530 |
2 |
Arun Raghavan <ford_prefect@g.o> wrote: |
3 |
> Ciaran McCreesh wrote: |
4 |
> > The benefit is that it's a logically separate action, and will avoid |
5 |
> > all the silliness of people repeatedly changing their minds about |
6 |
> > which phase should do the eautoreconf calls and so on. |
7 |
> |
8 |
> a) Is this really an issue for maintainers? |
9 |
|
10 |
It's not a huge issue, any more than src_configure is. Equally, it's not |
11 |
expensive to implement. |
12 |
|
13 |
> b) Does it really matter? |
14 |
|
15 |
In the grand scheme of things, no. In the grand scheme of things, you |
16 |
only *need* a single src_ function. From a maintainer convenience |
17 |
perspective, however, src_prepare is marginally more useful than having |
18 |
a split src_configure. |
19 |
|
20 |
> c) So the flow will look like: |
21 |
> |
22 |
> ... |
23 |
> src_unpack |
24 |
> src_prepare |
25 |
> src_configure |
26 |
> src_compile |
27 |
> ... |
28 |
> |
29 |
> To me this seems like an unnecessary overgeneralisation. |
30 |
|
31 |
It's a better mapping of the things ebuilds do than the current set of |
32 |
functions. |
33 |
|
34 |
The logic is this: lots of ebuilds end up duplicating src_unpack (or, |
35 |
in future EAPIs, calling 'default') and then adding things to do |
36 |
preparation work. Experience suggests that the most common reason for |
37 |
overriding src_unpack is to do preparation work, not to change how |
38 |
things are unpacked. |
39 |
|
40 |
(Number-wise... For Exherbo, where the split's already been made, |
41 |
custom src_prepare functions are three times more common than custom |
42 |
src_unpack functions. And that figure's significantly lower than what |
43 |
Gentoo would see, because with exheres-0 'default' functions you don't |
44 |
need to write a src_prepare if you're merely applying patches.) |
45 |
|
46 |
> The *only* potential "benefit" I see here is that at some point of |
47 |
> time in the nebulous future, it might be possible to tell the PM to |
48 |
> always skip src_prepare in order to give a system where everything is |
49 |
> "vanilla". |
50 |
|
51 |
Such a system wouldn't be usable... Not all of Gentoo's patches are |
52 |
non-essential. |
53 |
|
54 |
-- |
55 |
Ciaran McCreesh |