Re: [gentoo-dev] [python-single-r1 1/3] A conceptual eclass for packages not supporting multiple Python impls.

[Gilles Dartiguelongue]

Le mercredi 21 novembre 2012 à 23:19 +0100, Michał Górny a écrit :
> diff --git a/gx86/eclass/python-single-r1.eclass b/gx86/eclass/python-single-r1.eclass
> new file mode 100644
> index 0000000..3d21ea8
> --- /dev/null
> +++ b/gx86/eclass/python-single-r1.eclass
> @@ -0,0 +1,93 @@
> +# Copyright 1999-2012 Gentoo Foundation
> +# Distributed under the terms of the GNU General Public License v2
> +# $Header: /var/cvsroot/gentoo-x86/eclass/python-r1.eclass,v 1.20 2012/11/21 09:04:14 mgorny Exp $
> +
> +# @ECLASS: python-single-r1
> +# @MAINTAINER:
> +# Michał Górny <mgorny@g.o>
> +# Python herd <python@g.o>
> +# @AUTHOR:
> +# Author: Michał Górny <mgorny@g.o>
> +# Based on work of: Krzysztof Pawlik <nelchael@g.o>
> +# @BLURB: An eclass for Python packages not installed for multiple implementations.
> +# @DESCRIPTION:
> +# An extension of the python-r1 eclass suite for packages which
> +# don't support being installed for multiple Python implementations.
> +# This mostly includes tools embedding Python.
> +#
> +# This eclass extends the IUSE and REQUIRED_USE set by python-r1
> +# to request correct PYTHON_SINGLE_TARGET. It also replaces
> +# PYTHON_USEDEP and PYTHON_DEPS with a more suitable form.
> +#
> +# Please note that packages support multiple Python implementations
> +# (using python-r1 eclass) can not depend on packages not supporting
> +# them (using this eclass).
> +#
> +# Also, please note that python-single-r1 will always inherit python-r1
> +# as well. Thus, all the variables defined and documented there are
> +# relevant to the packages using python-single-r1.
> +
> +case "${EAPI}" in

you are missing the default EAPI value for EAPI=0 usually this is
written: case "${EAPI:-0}"

> +	0|1|2|3)
> +		die "Unsupported EAPI=${EAPI} (too old) for ${ECLASS}"
> +		;;
> +	4|5)
> +		# EAPI=4 needed by python-r1
> +		;;
> +	*)
> +		die "Unsupported EAPI=${EAPI} (unknown) for ${ECLASS}"
> +		;;
> +esac
> +

The rest looks fine.