Gentoo Archives: gentoo-dev

From: Michael Weber <xmw@g.o>
To: gentoo-dev@l.g.o
Subject: Re: [gentoo-dev] RFC: vcs-snapshot-r1.eclass -- a better eclass for VCS snapshots (and others)
Date: Tue, 12 Jun 2012 13:28:24
Message-Id: 4FD743A2.7010205@gentoo.org
In Reply to: [gentoo-dev] RFC: vcs-snapshot-r1.eclass -- a better eclass for VCS snapshots (and others) by "Michał Górny"
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

- From the eclass:

	# XXX: check whether the directory structure inside is
	# fine? i.e. if the tarball has actually a parent dir.

This should work with gnu and bsd tar, and sed+sort+wc from
sys-apps/coreutils as well as busybox.

[ $(bsdtar -t -f ~/keithw-mosh-mosh-1.2.1-0-g778b5af.zip \
	| sed 's:/.*::' | sort -u | wc -l) == 1 ]

I'm totally sure if we have to handle leading slashes and ./ in
obscure tars/zips but I'd say this tests qualifies for an
|| ewarn "Please check $f for an single parent directory"
or something like that.

My 2 cents

- --
Gentoo Dev
http://xmw.de/


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iF4EAREIAAYFAk/XQ6IACgkQknrdDGLu8JCXrQD/esMpA3z4jiZIsI3qkiz3zM7X
0I2ck7tG6WHGqTP/HEQA/jCAxkDt2hUXM+govuZaKrNHj5pBNvJIQNUF7VnzYKYr
=Lf4O
-----END PGP SIGNATURE-----

Replies