Gentoo Archives: gentoo-dev

From: Jonathan Callen <abcd@g.o>
To: gentoo-dev@l.g.o
Subject: [gentoo-dev] Re: metdata.dtd should require <herd/>
Date: Tue, 15 Dec 2009 18:38:35
Message-Id: 4B27CC07.8090005@gentoo.org
In Reply to: Re: [gentoo-dev] metdata.dtd should require by Peter Volkov
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Peter Volkov wrote:
> В Пнд, 07/12/2009 в 21:20 +0100, Thilo Bangert пишет: >> Hans de Graaff <graaff@g.o> said: >>> On Mon, 2009-12-07 at 12:56 +0100, Thilo Bangert wrote: >>>> dev-util/cucumber <herd> missing >>> Fixed, but this is really a bug in metadata.dtd, which specifies >>> <!ELEMENT pkgmetadata ( (herd|maintainer|longdescription|use| >>> upstream)* )> > >> indeed: http://bugs.gentoo.org/show_bug.cgi?id=279206 > > So what we will do with this? It'll be great to fix dtd to follow our > requirements, but there is a problem: > > if we change dtd like this: > > <!ELEMENT pkgmetadata ( herd+, (maintainer|longdescription|use|upstream)* )> > > we will force all metadata.xml files have strict order of tags: first > <herd/> then other tags. Currently there are about 200 ebuilds with > different order http://bugs.gentoo.org/show_bug.cgi?id=279206#c4 . > > Hans's suggestion http://bugs.gentoo.org/show_bug.cgi?id=279206#c7 works > but it is not nice and prohibits another order: herd, other tags, herd. > > Personally I'd kept dtd simple and forced ordering. > > So actually two questions here: > > 1. How should we fix dtd? > 2. Are there any problems if we fix dtd first and let maintainers fix > metadata.xml on bumps (iow, what will became broken if metadata.xml > became not valid)? >
One way to allow for any ordering, would be: <!ELEMENT pkgmetadata ( (maintainer|longdescription|use|upstream)*, herd, (herd|maintainer|longdescription|use|upstream)* )> - -- Jonathan Callen -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.13 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAksnzAcACgkQOypDUo0oQOo3TQCgnvrr5r54RE5q2LVRYoT+Q2nR 6Q4AniRGhT0Tq1KnY1wAoZt7c+ZEfBvQ =Inet -----END PGP SIGNATURE-----