| 1 |
Thomas Anderson wrote: |
| 2 |
|
| 3 |
> On Sat, Sep 06, 2008 at 12:43:12PM +0100, Steve Long wrote: |
| 4 |
>> Christian Faulhammer wrote: |
| 5 |
>> |
| 6 |
>> > Zac Medico <zmedico@g.o>: |
| 7 |
>> >> Both approaches are essentially equivalent but it's a little simpler |
| 8 |
>> >> for ebuild writer if they don't have to customize the output file |
| 9 |
>> >> name. |
| 10 |
>> > |
| 11 |
>> > One needs exceptions for all kind of systems, for example I had to |
| 12 |
>> > workaround Trac which adds ?format=raw to a tarball URI. There seems |
| 13 |
>> > to be a solution in Trac as the guys from fedarahosted fixed the two I |
| 14 |
>> > needed (tmpwatch, mlocate). So the -> operator is quite useful and I |
| 15 |
>> > agree with David that the functionality is doubled. |
| 16 |
>> > |
| 17 |
>> Clearly src-uri transformation is useful. Others have given examples of |
| 18 |
>> how it would be useful to an eclass. Irrespective of how the actual |
| 19 |
>> transform is done in the ;sf=tbz2 case, both _are_ valid use-cases. |
| 20 |
> |
| 21 |
> Sure they may be valid use cases, but the issue is whether the |
| 22 |
> ;sf=tar.bz2 code is duplicated from '->'. I don't see any reason why you |
| 23 |
> can't use '->' to handle ;sf=tbz2, so they are duplicated. Since '->' |
| 24 |
> can be used in more circumstances(SRC_URI="http://foo.com/2.3/foo.bz2 |
| 25 |
> -> ${P}.tar.bz2" comes to mind), we don't need ;sf=tbz2. |
| 26 |
|
| 27 |
You're confusing the code which implements, with the API thus provided. It's |
| 28 |
totally irrelevant whether the same code handles the functionality or not. |
| 29 |
(That's what encapsulation is about.) |
Archives